index: fix fs cache location #9969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
Sep 23, 2023
dvc/cachemgr.py
Outdated
| @@ -73,6 +74,16 @@ def __init__(self, repo): | |||
| legacy_odb = _get_odb(repo, settings, hash_name="md5-dos2unix", **kwargs) | |||
| self._odb["legacy"] = legacy_odb | |||
|
|
|||
| @property | |||
| def fs(self): | |||
There was a problem hiding this comment.
This will be confusing with fs the filesystem. Maybe file_storage or file_store?
There was a problem hiding this comment.
Also thought about that, but it is a property of cache manager, not particular cache. It is meant to mean fs_storage or fs_cache, since it is a per-fs cache. E.g. we have dvc.cache.local, dvc.cache.repo, dvc.cache.s3(obsoleted) and dvc.cache.fs. I'll rename it to fs_cache then.
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
skshetry
reviewed
Sep 23, 2023
| @@ -73,6 +74,16 @@ def __init__(self, repo): | |||
| legacy_odb = _get_odb(repo, settings, hash_name="md5-dos2unix", **kwargs) | |||
| self._odb["legacy"] = legacy_odb | |||
|
|
|||
| @property | |||
| def fs_cache(self): | |||
There was a problem hiding this comment.
Also could you please write a docstring on what this is being used for?
Existing logic might result in weird fs cache location like `.dvc/cache/files/md5/fs`, while we really only want `.dvc/cache/fs`, since it is not an odb cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logic might result in weird fs cache location like
.dvc/cache/files/md5/fs, while we really only want.dvc/cache/fs, since it is not an odb cache.