Skip to content

feat: Added archived badge #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2025
Merged

feat: Added archived badge #1078

merged 5 commits into from
Apr 30, 2025

Conversation

EGAMAGZ
Copy link
Contributor

@EGAMAGZ EGAMAGZ commented Apr 26, 2025

Fixes #1076

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 26, 2025

Desktop:
imagen

Mobile:
imagen

@AugustinMauroy
Copy link
Contributor

Humm interesting

Try to use something like jsr-yellow-600 because archived should be a warn not a danger.

@AugustinMauroy
Copy link
Contributor

to fix ci do :

cd api; cargo sqlx prepare

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 26, 2025 •
edited
Loading

I like how it looks with jsr-yellow-600. Great color selection

imagen

@EGAMAGZ EGAMAGZ force-pushed the feat/badge-indicator branch from bfab5b9 to 5b84242 Compare April 27, 2025 05:00
@EGAMAGZ EGAMAGZ marked this pull request as ready for review April 27, 2025 05:11
@crowlKats
Copy link
Collaborator

@EGAMAGZ can you include a screenshot in darkmode?

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 30, 2025 •
edited
Loading

This is how it will look like in dark theme @crowlKats

imagen

crowlKats
crowlKats approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats added this pull request to the merge queue Apr 30, 2025
Merged via the queue into jsr-io:main with commit 32e80d5 Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archived packages are not labelled as such in the scope package list for members
3 participants
@EGAMAGZ @AugustinMauroy @crowlKats