Skip to content

separate edit and view links #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minrk opened this issue Sep 9, 2016 · 1 comment · Fixed by #1905
Closed

separate edit and view links #1752

minrk opened this issue Sep 9, 2016 · 1 comment · Fixed by #1905

Comments

@minrk
Copy link
Member

minrk commented Sep 9, 2016

Some files, e.g. .html files, can logically be both viewed (via /files/) and edited (via /edit/). Currently, we have just the one link that goes to /edit/ or /files/, depending on the file type. We don't currently have separate links to these to URLs for files, but we probably should.

One option is to add view, edit to the list of actions along with delete, rename. Another is to add the links inline, perhaps on hover.

JupyterLab doesn't have this issue since it has an Open With... dialog, so if we take much longer to get around to this one, pointing to JupyterLab may end up being the solution.

I know this has been discussed a few places, but I can't find a dedicated issue for it, so opening here. If someone finds a duplicate, we can close this one.

cc @dsblank for interest, @ellisonbg for UI

@minrk minrk added this to the 4.3 milestone Sep 9, 2016
gnestor pushed a commit to gnestor/notebook that referenced this issue Nov 17, 2016
@takluyver
Copy link
Member

This is in progress in #1905, but we have identified a security concern with viewing HTML files, so we're bumping it to 5.0.

@takluyver takluyver modified the milestones: 5.0, 4.3 Nov 20, 2016
gnestor pushed a commit to gnestor/notebook that referenced this issue Jan 25, 2017
gnestor pushed a commit to gnestor/notebook that referenced this issue Jan 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants