Adds edit and view buttons, #1752 #1755
Conversation
| @@ -595,6 +597,20 @@ define([ | |||
| $('.delete-button').css('display', 'none'); | |||
| } | |||
|
|
|||
| // View is visible when an item is renderable or downloadable | |||
There was a problem hiding this comment.
I think these are only going to be appropriate for the length === 1 case. I don't think we can open all the selected files at once.
There was a problem hiding this comment.
I considered that, but I have already found this useful (eg, for "grading" in a non-nbgrader environment).
There was a problem hiding this comment.
Oh, I meant literally "can't" because I assumed the browser wouldn't let us open a bunch of new tabs/windows. Does it really work?
There was a problem hiding this comment.
As far as I have tested, it seems to work (Chrome). I had to create a local variable to assign the window to, otherwise I only got the one window. I haven't checked to see if there is a maximum number ... yet.
|
@dsblank I'm happy to help with this PR. Can you make the changes suggested by @minrk or check the "Allow edits from maintainers" box in the right column on this page and I will give it a try? |
|
@takluyver Sure thing! |
|
Thanks for picking this up! |
|
Closing this in favour of #1905, which build on it. |
Puts [Edit] and [View] buttons before the trashcan. Allows editing and viewing of files. Addresses #1752