mcs51: fix destination RAM type in XCHD A, @R0/@R1 #14289
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The initial value is read from internal RAM (IRAM_IR). - The final value must be written to the internal RAM too (IRAM_IW instead of IRAM_W).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I and @jyaif have found an issue in the mcs51's implementation of the
XCHD("Exchange Digit") instruction: it reads the old value withIRAM_IRbut writes the new value withIRAM_W.Instead, it should have written the new value symmetrically with
IRAM_IW:We found the issue while investigating a bad Dynamical Redefinable Character Set (DRCS) rendering on the minitel2 (
src/mame/philips/minitel_2_rpic.cpp).Before this patch:
After this patch:
(from MiniPavi service -> code
6212*DRCS-> image 1)cc @jfdelnero