vevent location backcompat #241
Conversation
|
Once #243 is merged, these builds should work again. |
gRegorLove
force-pushed
the
issue184
branch
from
c5adfb3 to
a71ee71
Compare
gRegorLove
requested review from
barnabywalters
and removed request for
Zegnat and
dshanske
There was a problem hiding this comment.
Should we consider changing use of indiewebcamp.com in examples into indieweb.org (and https as well) and similarly find another example instead of Geoloqi since that service has been shutdown by ESRI AFAIK, and the office location is not there anymore either. Perhaps a public institution address instead? Or a nod to Portland heritage like Powell's?
Use Powell's for vcard
There was a problem hiding this comment.
Much better! Fixed the prior mentioned issues, however in looking at it more closely I found this likely unintended dates inconsistency:
There are two instances of:
<time class="dtstart" datetime="2012-10-10">10 Nov 2012</time>
Problem: October in the ISO8601 datetime attribute vs "Nov" in the visible text content. Not sure which it should be but it should be consistent (unless this is testing an inconsistency error?).
@tantek discovered a mismatch between the datetime attribute and the displayed date. Confirmed the event was 2012-10-10, so updated the display date to match. See: https://cpj.org/2012/10/cpj-impact-43/ See: microformats/php-mf2#241
Originally this was PR #201 which got stale. I believe PR #234 fixed issue #184 properly. This just adds back the original tests that 201 was going to add, and a small update in Parser.php to indicate the
locationandvcardclasses were updated during backcompat.These tests passed as soon as I added them, so I think #184 is resolved.