[Feature] Add Swanlab Slack notification #4887
Open
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Swanlab notifications via Slack. This change introduces the `swanlab_notification_methods` parameter, allowing users to specify which notification channels (Lark and/or Slack) should be used to receive experiment updates. It also includes corresponding parameters for the Lark and Slack webhook URLs and necessary logic to register the appropriate callbacks based on the selected notification methods.
| @@ -83,14 +89,20 @@ def _init_swanlab(self): | |||
| if self.swanlab_token: | |||
| swanlab.login(self.swanlab_token) | |||
|
|
|||
| if self.swanlab_lark_webhook_url is not None: | |||
| if 'lark' in self.swanlab_notification_methods and self.swanlab_lark_webhook_url is not None: | |||
There was a problem hiding this comment.
An error will occur if self.swanlab_notification_methods is None.
There was a problem hiding this comment.
if self.swanlab_notification_methods and 'lark' in self.swanlab_notification_methods and self.swanlab_lark_webhook_url is not None:Would this argument be too long? Do you think if self.swanlab_notification_methods variable is needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Adds support for Swanlab notifications via Slack.
This change introduces the
swanlab_notification_methodsparameter, allowing users to specify which notification channels (Lark and/or Slack) should be used to receive experiment updates. It also includes corresponding parameters for the Lark and Slack webhook URLs and necessary logic to register the appropriate callbacks based on the selected notification methods.Related PR #4830 and Issue #4829.
Experiment results
clislackweb-ui