Skip to content

Pat/edit bookmarks #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Pat/edit bookmarks #566

merged 4 commits into from
May 5, 2025

Conversation

whlpatricia
Copy link
Collaborator

@whlpatricia whlpatricia commented May 5, 2025

Relevant Links

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1963396
TestRail: _

Description of Code / Doc Changes

  • Modified the test so that it no longer errors by avoiding the use of "other bookmarks"

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@whlpatricia whlpatricia requested a review from Tracy-Walker May 5, 2025 20:10
Tracy-Walker
Tracy-Walker previously approved these changes May 5, 2025
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@whlpatricia whlpatricia merged commit c735b0e into main May 5, 2025
6 checks passed
@whlpatricia whlpatricia deleted the Pat/edit_bookmarks branch May 5, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants