Skip to content

Pat/edit bookmarks #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Pat/edit bookmarks #566

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d1415e
fixed
whlpatricia May 5, 2025
11b3f9f
Merge branch 'main' into Pat/edit_bookmarks
whlpatricia May 5, 2025
69cb27e
fixed
whlpatricia May 5, 2025
98bc9f7
fixed
whlpatricia May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/bookmarks_and_history/test_edit_bookmark_from_bookmark_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def test_case():
"""


@pytest.mark.unstable(reason="https://bugzilla.mozilla.org/show_bug.cgi?id=1963396")
def test_edit_bookmark_from_bookmark_menu(driver: Firefox):
"""
C2084490: Verify that the user can Edit a Bookmark from Bookmarks menu
Expand Down Expand Up @@ -47,13 +46,15 @@ def test_edit_bookmark_from_bookmark_menu(driver: Firefox):
panel.get_element("other-bookmarks").click()
nav.get_element("save-bookmark-button").click()

# Temporary fix before the other bookmarks issue is fixed
nav.get_element("star-button").click()
assert panel.get_element("bookmark-location").get_attribute("label") == "Other Bookmarks"
# Check bookmark name and location are changed in the bookmarks toolbar
panel.get_element("other-bookmarks-toolbar").click()
panel.element_visible("other-bookmarks-by-title", labels=["Mozilla Firefox"])
panel.get_element("other-bookmarks-toolbar").click()
# panel.get_element("other-bookmarks-toolbar").click()
# panel.element_visible("other-bookmarks-by-title", labels=["Mozilla Firefox"])
# panel.get_element("other-bookmarks-toolbar").click()

# Check tags are correctly added and checked
nav.get_element("star-button").click()
panel.get_element("extend-bookmark-tags").click()
work_checkbox = panel.get_element("work-tag")
work_checked_attr = work_checkbox.get_attribute("checked")
Expand Down