Skip to content

Switch nodemon over to tsc-watch, enable incremental builds. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Sacro
Copy link
Contributor

@Sacro Sacro commented Mar 29, 2019

Now tsc 3.4.1 is out, we can use some of the new features. I've left the tsconfig files as-is aside from excluding the "dist" folder.

@kamilmysliwiec
Copy link
Member

Is tsc-watch library mature enough to recommend its usage in the starter project? Results look promising and we should definitely take advantage of the new incremental builds in TS. I'm slightly afraid about tsc-watch though.

@Sacro
Copy link
Contributor Author

Sacro commented Mar 31, 2019

Looking at the tsc-watch bugs, it seems it does have issues with non English locales, that's not great. I'll see what alternatives there are.

@kamilmysliwiec
Copy link
Member

What about running tsc --watch and nodemon concurrently?

@Sacro
Copy link
Contributor Author

Sacro commented Apr 3, 2019

That would work, but the nice thing about tsc-watch is it waits for the build to be succesful or to fail before moving on. Using wait-on alongside concurrently might be a nice solution

@kamilmysliwiec
Copy link
Member

True. Anyways, tsc + nodemon sounds like a more stable integration + is much faster. Should we move with this one for now? :)

@Sacro
Copy link
Contributor Author

Sacro commented Apr 8, 2019

Sounds good to me

@Sacro
Copy link
Contributor Author

Sacro commented Apr 8, 2019

I'll close this and we can move to #124

@Sacro Sacro closed this Apr 8, 2019
@Sacro Sacro deleted the tsc-watch branch April 8, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants