Skip to content

Use concurrently and wait-on for fast incremental builds #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Use concurrently and wait-on for fast incremental builds #124

wants to merge 11 commits into from

Conversation

Sacro
Copy link
Contributor

@Sacro Sacro commented Apr 8, 2019

No description provided.

@Sacro Sacro mentioned this pull request Apr 8, 2019
Closed
@Sacro
Copy link
Contributor Author

Sacro commented Apr 8, 2019

Maybe we could consider removing ts-node as it's only used in start now.

kamilmysliwiec
kamilmysliwiec reviewed Apr 15, 2019
View reviewed changes
nodemon.json Outdated
"exec": "ts-node -r tsconfig-paths/register src/main.ts"
"watch": ["dist"],
"ext": "js",
"exec": "node -r tsconfig-paths/register -r ts-node/register dist/main.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 -r tsconfig-paths/register -r ts-node/register

Why are these required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 -r tsconfig-paths/register -r ts-node/register

Why are these required?

tsconfig-paths is used when people use paths in their tsconfig.json to map things in.

ts-node/register can be dropped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsconfig-paths is used when people use paths in their tsconfig.json to map things in.

Are you sure that it will still work after compilation? tsconfig-paths is used with combination with the ts-node

@kamilmysliwiec
Copy link
Member

Maybe we could consider removing ts-node as it's only used in start now.

We shouldn't because it's being used by start.

@Sacro
Copy link
Contributor Author

Sacro commented Apr 15, 2019

Maybe we could consider removing ts-node as it's only used in start now.

We shouldn't because it's being used by start.

Right, but we could move that off ts-node surely?

@kamilmysliwiec
Copy link
Member

If you run npm run start:dev in a row (2 times), it won't start your app. Since TS caches the build info in a dedicated file now, once you try to rerun start:dev (without changing a line of code), it won't trigger the build = wait-on will hang out the process.

@Sacro
Copy link
Contributor Author

Sacro commented Apr 18, 2019 •
edited
Loading

If you run npm run start:dev in a row (2 times), it won't start your app. Since TS caches the build info in a dedicated file now, once you try to rerun start:dev (without changing a line of code), it won't trigger the build = wait-on will hang out the process.

It's not outputting to dist when you delete it, so it makes sense to not delete it and keep the .tsbuildinfo file in its default location.

@kamilmysliwiec
Copy link
Member

LGTM

@Sacro Sacro deleted the wait-on-concurrently branch April 23, 2019 09:52
@JeremyLoy JeremyLoy mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sacro @kamilmysliwiec