Helm and function signature refactors #4758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
pdabelf5
approved these changes
Dec 6, 2023
…nc/kubernetes-ingress into helm-args-and-config-sig-refactor
shaun-nx
approved these changes
Dec 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4758 +/- ##
==========================================
+ Coverage 52.09% 52.14% +0.05%
==========================================
Files 59 59
Lines 17033 17083 +50
==========================================
+ Hits 8873 8908 +35
- Misses 7862 7875 +13
- Partials 298 300 +2 ☔ View full report in Codecov by Sentry. |
pdabelf5
pushed a commit
that referenced
this pull request
Dec 7, 2023
* refactor helm args for deploy and daemonset, refactor several function signatures
pdabelf5
added a commit
that referenced
this pull request
Dec 8, 2023
* Bump the go group with 3 updates Bumps the go group with 3 updates: [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/service/marketplacemetering](https://github.com/aws/aws-sdk-go-v2) and [github.com/nginxinc/nginx-prometheus-exporter](https://github.com/nginxinc/nginx-prometheus-exporter). Updates `github.com/aws/aws-sdk-go-v2/config` from 1.25.10 to 1.25.12 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.25.10...config/v1.25.12) Updates `github.com/aws/aws-sdk-go-v2/service/marketplacemetering` from 1.19.1 to 1.19.3 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.19.1...service/mq/v1.19.3) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/service/marketplacemetering dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]> * Helm and function signature refactors (#4758) * refactor helm args for deploy and daemonset, refactor several function signatures * update helm k8s schema validation to 1.28.0 (#4763) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: oseoin <[email protected]> Co-authored-by: Paul Abel <[email protected]> Co-authored-by: Paul Abel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
generateNginxCfg()generateNginxCfgForMergeableIngresses()NewConfigurator()Checklist
Before creating a PR, run through this checklist and mark each as complete.