Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 7, 2023

Proposed changes

update helm k8s schema validation to 1.28.0

tested with

helm template k8sversion charts/nginx-ingress

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 7, 2023 10:45
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Dec 7, 2023
@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e89b329) 52.14% compared to head (681c07f) 52.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4763      +/-   ##
==========================================
+ Coverage   52.14%   52.18%   +0.03%     
==========================================
  Files          59       59              
  Lines       17083    17083              
==========================================
+ Hits         8908     8914       +6     
+ Misses       7875     7871       -4     
+ Partials      300      298       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 self-assigned this Dec 7, 2023
@pdabelf5 pdabelf5 merged commit 7a4e579 into main Dec 7, 2023
@pdabelf5 pdabelf5 deleted the k8s-schema-updates branch December 7, 2023 12:43
pdabelf5 added a commit that referenced this pull request Dec 8, 2023
* Bump the go group with 3 updates

Bumps the go group with 3 updates: [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/service/marketplacemetering](https://github.com/aws/aws-sdk-go-v2) and [github.com/nginxinc/nginx-prometheus-exporter](https://github.com/nginxinc/nginx-prometheus-exporter).


Updates `github.com/aws/aws-sdk-go-v2/config` from 1.25.10 to 1.25.12
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.25.10...config/v1.25.12)

Updates `github.com/aws/aws-sdk-go-v2/service/marketplacemetering` from 1.19.1 to 1.19.3
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v1.19.1...service/mq/v1.19.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
- dependency-name: github.com/aws/aws-sdk-go-v2/service/marketplacemetering
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
...

Signed-off-by: dependabot[bot] <[email protected]>

* Helm and function signature refactors (#4758)

* refactor helm args for deploy and daemonset, refactor several function signatures

* update helm k8s schema validation to 1.28.0 (#4763)


---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: oseoin <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm_chart Pull requests that update the Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants