Skip to content

ENH: Putting the new API together on a base workflow #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Dec 3, 2020

Finalizes the new API, showing how the new SDCFlows works.

Finalizes the new API, showing how the new SDCFlows works.
@oesteban oesteban force-pushed the enh/workflow-creation branch from 2c9f53a to bd84deb Compare December 4, 2020 09:28
@oesteban oesteban marked this pull request as ready for review December 4, 2020 09:30
- BUGFIX: the ``IntraModalMerge`` interface of the fieldmap workflow lacked
  a ``to_ras=False`` setting.
- ENH: the TOPUP workflow now uses ``Flatten`` (as the 3dQwarp did) to massage
  EPIs before processing (and allowing to remove one ``IntraModalMerge`` on
  unit tests.
- ENH: the TOPUP workflow now generates a single-volume merged output after
  correction.
- ENH: tests are using the ``outdir`` fixture in a better way.
@oesteban oesteban force-pushed the enh/workflow-creation branch from bd84deb to ca7fd50 Compare December 4, 2020 10:50
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #143 (ca7fd50) into dev/1.4.0 (68ab2fe) will increase coverage by 0.92%.
The diff coverage is 94.52%.

Impacted file tree graph

@@              Coverage Diff              @@
##           dev/1.4.0     #143      +/-   ##
=============================================
+ Coverage      93.65%   94.57%   +0.92%     
=============================================
  Files             18       19       +1     
  Lines           1040     1069      +29     
  Branches         136      140       +4     
=============================================
+ Hits             974     1011      +37     
+ Misses            39       32       -7     
+ Partials          27       26       -1     
Flag Coverage Δ
travis 80.52% <69.86%> (-1.39%) ⬇️
unittests 94.36% <94.52%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/workflows/fit/fieldmap.py 98.41% <ø> (ø)
sdcflows/workflows/outputs.py 91.37% <ø> (ø)
sdcflows/utils/wrangler.py 90.69% <90.69%> (ø)
sdcflows/fieldmaps.py 85.71% <100.00%> (ø)
sdcflows/workflows/base.py 100.00% <100.00%> (+4.34%) ⬆️
sdcflows/workflows/fit/pepolar.py 100.00% <100.00%> (ø)
sdcflows/viz/utils.py 98.00% <0.00%> (+2.00%) ⬆️
sdcflows/interfaces/reportlets.py 86.44% <0.00%> (+5.08%) ⬆️
sdcflows/interfaces/fmap.py 96.96% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ab2fe...ca7fd50. Read the comment docs.

@oesteban oesteban merged commit 343e382 into nipreps:dev/1.4.0 Dec 4, 2020
@oesteban oesteban deleted the enh/workflow-creation branch December 4, 2020 11:32
oesteban added a commit that referenced this pull request Dec 24, 2020
2.0.0rc4

* FIX: Convert SEI fieldmaps given in rad/s into Hz (#127)
* FIX: Limit ``3dQwarp`` to maximum 4 CPUs for stability reasons (#128)
* ENH: Generate a simple mask after correction (#161)
* ENH: Increase unit-tests coverage of ``sdcflows.fieldmaps`` (#159)
* ENH: Optimize tensor-product B-Spline kernel evaluation (#157)
* ENH: Add a memory check to dynamically limit interpolation blocksize (#156)
* ENH: Massage TOPUP's fieldcoeff files to be compatible with ours (#154)
* ENH: Add a simplistic EPI masking algorithm (#152)
* ENH: Utility that returns the ``B0FieldSource`` of a given potential EPI target (#151)
* ENH: Write ``fmapid-`` entity in Derivatives (#150)
* ENH: Multiplex fieldmap estimation outputs into a single ``outputnode`` (#149)
* ENH: Putting the new API together on a base workflow (#143)
* ENH: Autogenerate ``B0FieldIdentifiers`` from ``IntendedFor`` (#142)
* ENH: Finalizing the API overhaul (#132)
* ENH: Keep a registry of already-used identifiers (and auto-generate new) (#130)
* ENH: New objects for better representation of fieldmap estimation (#114)
* ENH: Show FieldmapReportlet oriented aligned with cardinal axes (#120)
* ENH: New estimation API (featuring a TOPUP implementation!) (#115)
* DOC: Minor improvements to the literate workflows descriptions. (#162)
* DOC: Fix typo in docstring (#155)
* DOC: Enable NiPype's sphinx-extension to better render Interfaces (#131)
* MAINT: Drop Python 3.6 (#160)
* MAINT: Enable Git-archive protocol with setuptools-scm-archive (#153)
* MAINT: Migrate TravisCI -> GH Actions (completion) (#138)
* MAINT: Migrate TravisCI -> GH Actions (#137)
* MAINT: Minimal unit test and refactor of pepolar workflow node (#133)
* MAINT: Collect code coverage from tests on Circle (#122)
* MAINT: Test minimum dependencies with TravisCI (#96)
* MAINT: Add FLIRT config files to prepare for TOPUP integration (#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant