Skip to content

cli: handle spinning states #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022
Merged

cli: handle spinning states #657

merged 3 commits into from
Nov 30, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 6, 2022

Fixes the annoying bug, when a question is asked through the client and a spinner is already taken place. This pull request, pauses and restarts the spinner after the answer.

Example:
screen_shot_2022-10-22_at_6 58 55_pm_720

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 83.60% // Head: 83.41% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (a6f996d) compared to base (3b5c232).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   83.60%   83.41%   -0.19%     
==========================================
  Files          37       37              
  Lines        4117     4131      +14     
==========================================
+ Hits         3442     3446       +4     
- Misses        675      685      +10     
Impacted Files Coverage Δ
lib/cli.js 86.45% <75.00%> (-1.19%) ⬇️
lib/verbosity.js 73.07% <0.00%> (-7.70%) ⬇️
lib/ci/run_ci.js 75.00% <0.00%> (-3.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests?

@anonrig anonrig force-pushed the fix/spinner branch 2 times, most recently from b91d791 to da0438f Compare November 29, 2022 17:57
@anonrig anonrig requested a review from aduh95 November 29, 2022 17:57
@anonrig
Copy link
Member Author

anonrig commented Nov 29, 2022

@aduh95 @Trott Can you review the last 2 commits?

  • I added the first commit, even though it was handled by the try catch, to remove the unnecessary debug error on the input.
  • Secondly, mocha tests were not terminating, and mocha docs mentioned --exit.

@aduh95 aduh95 merged commit 35ef99f into nodejs:main Nov 30, 2022
@anonrig anonrig deleted the fix/spinner branch November 30, 2022 13:41
@ShogunPanda
Copy link

Hello folks! This is very cool. When can we expect this to be released in NPM?

@targos
Copy link
Member

targos commented Dec 6, 2022

This wasn't merged with a conventional commit message, so the release-please action didn't create a PR.
We would need to merge another fix/feat, or create an empty commit with a good message.

@ShogunPanda
Copy link

Do you mean a commit directly on the main branch?

@aduh95
Copy link
Contributor

aduh95 commented Dec 6, 2022

Sorry, I was fooled by the green CI. I've pushed 51a3b24 to fix it.

@anonrig
Copy link
Member Author

anonrig commented Dec 6, 2022

For future references, what was missing from the pull request?

@Trott
Copy link
Member

Trott commented Dec 11, 2022

For future references, what was missing from the pull request?

I believe this repo is using release-please so the commit message needs to confirm to the expectations of release-please. Yup, the commit message requirements here are different than in the core repo. ¯\(ツ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants