-
Notifications
You must be signed in to change notification settings - Fork 116
cli: handle spinning states #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 83.60% // Head: 83.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 83.60% 83.41% -0.19%
==========================================
Files 37 37
Lines 4117 4131 +14
==========================================
+ Hits 3442 3446 +4
- Misses 675 685 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests?
b91d791
to
da0438f
Compare
Hello folks! This is very cool. When can we expect this to be released in NPM? |
This wasn't merged with a conventional commit message, so the release-please action didn't create a PR. |
Do you mean a commit directly on the main branch? |
Sorry, I was fooled by the green CI. I've pushed 51a3b24 to fix it. |
For future references, what was missing from the pull request? |
I believe this repo is using release-please so the commit message needs to confirm to the expectations of release-please. Yup, the commit message requirements here are different than in the core repo. ¯\(ツ)/¯ |
Fixes the annoying bug, when a question is asked through the client and a spinner is already taken place. This pull request, pauses and restarts the spinner after the answer.
Example:
