Skip to content

cli: handle spinning states #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022
Merged

cli: handle spinning states #657

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c76d49
feat(cli): handle spinning states
anonrig Nov 6, 2022
0ac1071
fix: handle uncaught error on unit test
anonrig Nov 29, 2022
a6f996d
fix: add missing --exit option to mocha
anonrig Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: handle uncaught error on unit test
  • Loading branch information
@anonrig
anonrig committed Nov 29, 2022
commit 0ac1071ce30fbc5245d26b5fa3d54d24f1dbeb8a
1 change: 1 addition & 0 deletions test/unit/ci_start.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ describe('Jenkins', () => {
it('should fail if starting node-pull-request throws', async() => {
const cli = new TestCLI();
const request = {
fetch: sinon.stub().returns(Promise.resolve({ status: 400 })),
text: sinon.stub().throws(),
json: sinon.stub().withArgs(CI_CRUMB_URL)
.returns(Promise.resolve({ crumb }))
Expand Down