Add label attribute for LAG and virtual router #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kcudnik <[email protected]>
marian-pritsak
approved these changes
Nov 22, 2020
Collaborator
|
apart from warm reboot use case, what are other use cases? can we get more concrete? @marian-pritsak |
kcudnik
changed the title
lguohan
approved these changes
Nov 25, 2020
rlhui
pushed a commit
that referenced
this pull request
Feb 18, 2022
Counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify object during warmboot scenarios. This is similar to existing label attribute used by LAG and virtual router. The attribute is considered as user data attached to the object. Related to: #1158 Signed-off-by: Midhun Somasundaran [email protected]
shri-khare
added a commit
to shri-khare/SAI
that referenced
this pull request
Mar 6, 2022
Summary: This is similar to opencomputeproject#1158 and opencomputeproject#1407. Those PRs added label attribute for LAG/virtual router and counter. This PR adds similar label attribute for ACL counter. ACL counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify ACL counter object during warmboot. The attribute is considered as user data attached to the object. Signed-off-by: Shrikrishna Khare <[email protected]>
rlhui
pushed a commit
that referenced
this pull request
Mar 13, 2022
Summary: This is similar to #1158 and #1407. Those PRs added label attribute for LAG/virtual router and counter. This PR adds similar label attribute for ACL counter. ACL counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify ACL counter object during warmboot. The attribute is considered as user data attached to the object. Signed-off-by: Shrikrishna Khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LAG and virtual router can be created without any unique mandatory attributes, anchor attribute can be used to uniquely identify specified objects. This will be very useful in SONiC warm boot scenario, for example to identify 2 empty LAGs which are present on the device after reboot.
This attribute doesn't correspond to any internal SAI vendor device resources, and at this point it don't need to be implemented by any vendor, it implementation at create function internals CAN be skipped without posting error. This attribute is considered as user data attached to specific object.
If vendor wants to support this attribute it should also be persistent over warm boot scenario
Cons: extra attribute, that has no actual resource meaning and it would need to be added to objects that need to be uniquely identified on user side
Pros: convenient for SONiC, since metadata for all attributes is auto generated, and it will make very easy to to use existing attribute, instead of making convoluted way to pass extra information from sairedis/syncd path (this is because of current SONiC architecture design in sairedis/syncd model)
Related to:
#1080
#1132