Add label attribute for ACL counter #1430
Conversation
Summary: This is similar to opencomputeproject#1158 and opencomputeproject#1407. Those PRs added label attribute for LAG/virtual router and counter. This PR adds similar label attribute for ACL counter. ACL counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify ACL counter object during warmboot. The attribute is considered as user data attached to the object. Signed-off-by: Shrikrishna Khare <[email protected]>
|
Thanks @kcudnik for the quick review. I notice that 1.10 was tagged only yesterday morning #1429. Otherwise, we would have to wait till the next SAI Spec revision (what is the timeline for that?) before we could configure multiple ACL counters in the same table and warmboot. cc @rlhui Thank you! |
|
@kcudnik , @rlhui, following up my question. This is a relatively straightforward PR that will help during warmboot with ACL counters. It just missed 1.10 revision. Would it be possible to include it in 1.10.2 (say), so we could configure multiple ACL counters in the same table without needing to wait for the next SAI spec revision (which might be some time away?) Thanks,
|
|
@JaiOCP , would you like to review/approve this? thanks. |
Reviewed. Thanks |
4 participants
Summary:
This is similar to #1158 and #1407.
Those PRs added label attribute for LAG/virtual router and counter. This
PR adds similar label attribute for ACL counter.
ACL counter does not have any mandatory attribute to identify object
uniquely. Adding a label attribute that can be used to uniquely identify
ACL counter object during warmboot. The attribute is considered as user
data attached to the object.
Signed-off-by: Shrikrishna Khare [email protected]