-
Notifications
You must be signed in to change notification settings - Fork 659
CONSOLE-4381: upgrade PatternFly to v6 #14621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rhamilto: This pull request references CONSOLE-4381 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4c5fbe6
to
226cd25
Compare
4d0c203
to
25cd8d5
Compare
050ef42
to
77155ba
Compare
/retest |
/test okd-scos-e2e-aws-ovn |
/test e2e-gcp-console |
/label px-approved |
@rhamilto: This pull request references CONSOLE-4381 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @sanketpathak for dev console QE review |
@yapei and @sanketpathak, when reviewing, I ask that you only block on major issues that would mean the console is fundamentally broken. We know there are minor issues that need cleanup, but we'll address those in follow ons. |
Adding final label per a Slack message from @yapei so this can test and merge. |
@rhamilto: This pull request references CONSOLE-4381 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label qe-approved |
/test e2e-gcp-console |
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
Thank you @rhamilto 🚀 |
In collaboration with: @kmcfaul, @nicolethoen, @Mylanos, @logonoff, @vikram-raj, @lokanandaprabhu, @cajieh, @sg00dwin, etc. Thank you!
NOTE: the intention here is not to have one PR that makes everything perfect, but rather one that lays a solid foundation on which follow-up work can be done to address anything not covered.
TODO:
--pf-v6-
(there are quite a few invalid variables that need to be updated to a PF6 equivalent)// TODO: PF6 upgrade
TODO in follow-ons:
// TODO: PF6 upgrade