Skip to content

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Dec 12, 2024

In collaboration with: @kmcfaul, @nicolethoen, @Mylanos, @logonoff, @vikram-raj, @lokanandaprabhu, @cajieh, @sg00dwin, etc. Thank you!

NOTE: the intention here is not to have one PR that makes everything perfect, but rather one that lays a solid foundation on which follow-up work can be done to address anything not covered.

TODO:

  • Add back PatternFly 5 CSS
  • Verify CSS variables prefixed with --pf-v6- (there are quite a few invalid variables that need to be updated to a PF6 equivalent)
  • Fix issues commented with // TODO: PF6 upgrade
  • Fix failing unit and integration tests
  • Update i18n strings (there are known issues stemming from unresolved TODOs)

TODO in follow-ons:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2024

@rhamilto: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/lso Related to local-storage-operator-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Dec 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2024
@openshift-ci openshift-ci bot added the component/metal3 Related to metal3-plugin label Dec 17, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@Mylanos
Copy link
Contributor

Mylanos commented Feb 4, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Feb 4, 2025

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

rhamilto commented Feb 4, 2025

/test e2e-gcp-console

@reestr
Copy link

reestr commented Feb 4, 2025

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2025

@rhamilto: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

In collaboration with: @kmcfaul, @nicolethoen, @Mylanos, @logonoff, @vikram-raj, @lokanandaprabhu, @cajieh, @sg00dwin, etc. Thank you!

NOTE: the intention here is not to have one PR that makes everything perfect, but rather one that lays a solid foundation on which follow-up work can be done to address anything not covered.

TODO:

  • Add back PatternFly 5 CSS
  • Verify CSS variables prefixed with --pf-v6- (there are quite a few invalid variables that need to be updated to a PF6 equivalent)
  • Fix issues commented with // TODO: PF6 upgrade
  • Diagnose and fix issue with catalog view opening a new tab on click of a card (@nicolethoen fixed with fix: prevent console errors for read only badges in card actions patternfly/react-catalog-view#76, needs merging and new release of @patternfly/react-catalog-view)
  • Update old form styles from approximating PF5 to approximating PF6 (@logonoff)
  • Fix failing unit and integration tests
  • Update i18n strings (there are known issues stemming from unresolved TODOs)

TODO in follow-ons:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member

logonoff commented Feb 4, 2025

/retest

@logonoff
Copy link
Member

logonoff commented Feb 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member

logonoff commented Feb 4, 2025

/assign @sanketpathak

for dev console QE review

@rhamilto
Copy link
Member Author

rhamilto commented Feb 4, 2025

@yapei and @sanketpathak, when reviewing, I ask that you only block on major issues that would mean the console is fundamentally broken. We know there are minor issues that need cleanup, but we'll address those in follow ons.

@rhamilto
Copy link
Member Author

rhamilto commented Feb 5, 2025

Adding final label per a Slack message from @yapei so this can test and merge.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2025

@rhamilto: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

In collaboration with: @kmcfaul, @nicolethoen, @Mylanos, @logonoff, @vikram-raj, @lokanandaprabhu, @cajieh, @sg00dwin, etc. Thank you!

NOTE: the intention here is not to have one PR that makes everything perfect, but rather one that lays a solid foundation on which follow-up work can be done to address anything not covered.

TODO:

  • Add back PatternFly 5 CSS
  • Verify CSS variables prefixed with --pf-v6- (there are quite a few invalid variables that need to be updated to a PF6 equivalent)
  • Fix issues commented with // TODO: PF6 upgrade
  • Diagnose and fix issue with catalog view opening a new tab on click of a card (@nicolethoen fixed with fix: prevent console errors for read only badges in card actions patternfly/react-catalog-view#76, needs merging and new release of @patternfly/react-catalog-view)
  • Update old form styles from approximating PF5 to approximating PF6 (@logonoff)
  • Fix failing unit and integration tests
  • Update i18n strings (there are known issues stemming from unresolved TODOs)

TODO in follow-ons:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei
Copy link
Contributor

yapei commented Feb 5, 2025

/label qe-approved

@rhamilto
Copy link
Member Author

rhamilto commented Feb 5, 2025

/test e2e-gcp-console

@sanketpathak
Copy link
Contributor

Tested developer perspective
Screenshot From 2025-02-05 23-25-27
Screenshot From 2025-02-05 23-25-51
Screenshot From 2025-02-05 23-26-18
Screenshot From 2025-02-05 23-27-03
Screenshot From 2025-02-05 23-34-24

/label qe-approved

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1afcc88 into openshift:master Feb 5, 2025
7 checks passed
@rhamilto rhamilto deleted the CONSOLE-4381 branch February 5, 2025 21:05
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202502052306.p0.g1afcc88.assembly.stream.el9.
All builds following this will include this PR.

@jhadvig
Copy link
Member

jhadvig commented Feb 11, 2025

Thank you @rhamilto 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.