Skip to content

Conversation

logonoff
Copy link
Member

What: Closes #11351

Additional issues: openshift/console#14621

@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 18, 2024

...props
}: CardHeaderProps) => {
const uniqueId = React.useId();
const uniqueId = lodashId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are avoid using lodash in our react-core We actually had a tech debt issu to remove it entirely from the library. Could you please use our utility functions instead.

https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/helpers/GenerateId/GenerateId.ts

@tlabaj tlabaj requested a review from thatblindgeye December 18, 2024 21:24
@tlabaj tlabaj merged commit 1c3dd97 into patternfly:main Dec 19, 2024
13 checks passed
mattnolting pushed a commit to mattnolting/patternfly-react that referenced this pull request Feb 14, 2025
…ternfly#11357)

* fix: replace react useId with lodash uniqueId (patternfly#11351)

* fix: use `GenerateId` instead of lodash.uniqueId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - PF is using useId hook that is not supported by React 17

4 participants