Update cmake minimum version to 2.8.12 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI jobs
This PR didn't appear to resolve the issue yet. Perhaps we'll have to wait until googletest is patched upstream. I'm not sure, it will take a bit more fussing. |
Contributor
Author
|
Trying to set the deprecated policy manually
|
Contributor
Author
|
Trying again: |
Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/testing-tools-cmake-minimum-version
branch
from
65f7012 to
49750d3
Compare
Contributor
Author
|
Rebasing onto master and trying a max cmake version as well. |
brawner
force-pushed
the
brawner/testing-tools-cmake-minimum-version
branch
from
0ba7c31 to
0f4a54e
Compare
Contributor
Author
|
Creating a manually patched archive |
brawner
force-pushed
the
brawner/testing-tools-cmake-minimum-version
branch
from
0f4a54e to
40fc8e9
Compare
Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/testing-tools-cmake-minimum-version
branch
from
40fc8e9 to
56e9891
Compare
Contributor
Author
|
Just setting cmake_minimum_required explicitly, no fancy stuff |
Contributor
Author
|
An upstream PR to handle this is in the works google/googletest#3094 |
Member
|
Please use the scheme here: |
Member
|
Otherwise we may step on others and/or confuse people if upstream starts using x.y.z.a versioning. |
Contributor
Author
|
Ok, I think I have the patch version updated correctly.
|
wjwwood
reviewed
Nov 25, 2020
osrf_testing_tools_cpp/cmake/osrf_testing_tools_cpp_get_googletest_versions.cmake
Outdated
Show resolved
Hide resolved
brawner
force-pushed
the
brawner/testing-tools-cmake-minimum-version
branch
from
3ec6e93 to
56e9891
Compare
Contributor
Author
|
Removing last commit
|
wjwwood
approved these changes
Nov 26, 2020
Member
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
Thanks for updating it again.
Sorry!
chapulina
pushed a commit
that referenced
this pull request
Apr 21, 2021
* Update cmake minimum version to 2.8.12 Signed-off-by: Stephen Brawner <[email protected]> * Try setting policy explicitly Signed-off-by: Stephen Brawner <[email protected]> * Trying this Signed-off-by: Stephen Brawner <[email protected]> * Manually patching archive Signed-off-by: Stephen Brawner <[email protected]>
wjwwood
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Update cmake minimum version to 2.8.12 (#61) * Update cmake minimum version to 2.8.12 Signed-off-by: Stephen Brawner <[email protected]> * Try setting policy explicitly Signed-off-by: Stephen Brawner <[email protected]> * Trying this Signed-off-by: Stephen Brawner <[email protected]> * Manually patching archive Signed-off-by: Stephen Brawner <[email protected]> * Use VERSION_GREATER instead of GREATER Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Stephen Brawner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most recent release of cmake (3.19), they have started deprecating cmake versions <
2.8.12.Example cmake warnings
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1760/cmake/
Build all of ros2, testing up to
rcutilsSigned-off-by: Stephen Brawner [email protected]