-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
Noticed in #2838 (review).
It seems like the elimination of PropertiesTable.Group
in #2723 means we have an ordering problem. We write the code to represent the cells left to right. We might be able to fix this by changing the component so it goes by column instead of by row. We'd have to update all the existing call sites.
console/app/pages/system/inventory/sled/SledPage.tsx
Lines 47 to 61 in 3da27b7
<PropertiesTable.Row label="sled id"> | |
<span className="text-default">{sled.id}</span> | |
</PropertiesTable.Row> | |
<PropertiesTable.Row label="policy kind"> | |
<SledKindBadge policy={sled.policy} /> | |
</PropertiesTable.Row> | |
<PropertiesTable.Row label="part"> | |
<span className="text-default">{sled.baseboard.part}</span> | |
</PropertiesTable.Row> | |
<PropertiesTable.Row label="provision policy"> | |
<ProvisionPolicyBadge policy={sled.policy} /> | |
</PropertiesTable.Row> | |
<PropertiesTable.Row label="serial"> | |
<span className="text-default">{sled.baseboard.serial}</span> | |
</PropertiesTable.Row> |
Two columns

One column

Metadata
Metadata
Assignees
Labels
No labels