Skip to content

PropertiesTable row order appears different when 1 col vs 2 #2847

@david-crespo

Description

@david-crespo

Noticed in #2838 (review).

It seems like the elimination of PropertiesTable.Group in #2723 means we have an ordering problem. We write the code to represent the cells left to right. We might be able to fix this by changing the component so it goes by column instead of by row. We'd have to update all the existing call sites.

<PropertiesTable.Row label="sled id">
<span className="text-default">{sled.id}</span>
</PropertiesTable.Row>
<PropertiesTable.Row label="policy kind">
<SledKindBadge policy={sled.policy} />
</PropertiesTable.Row>
<PropertiesTable.Row label="part">
<span className="text-default">{sled.baseboard.part}</span>
</PropertiesTable.Row>
<PropertiesTable.Row label="provision policy">
<ProvisionPolicyBadge policy={sled.policy} />
</PropertiesTable.Row>
<PropertiesTable.Row label="serial">
<span className="text-default">{sled.baseboard.serial}</span>
</PropertiesTable.Row>

Two columns

Image

One column

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions