-
Notifications
You must be signed in to change notification settings - Fork 13
Add sled policy data to sled page #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We have this second layer of header in the list view to explain what "kind" means and to group kind and provision policy like they are in the response. (Though to be honest it's still not particularly intuitive.) We can't quite do that here, but calling kind "policy kind" might help. On the other hand it might look weird to have "policy kind" and "provision policy". Maybe @benjaminleonard will have an idea. ![]() console/app/api/__generated__/Api.ts Lines 3632 to 3644 in e71c828
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It seems like the elimination of PropertiesTable.Group
in #2723 means we have an ordering problem. We might be able to fix this by changing the component so it goes by column instead of by row? Making a separate issue for this.

oxidecomputer/console@e891f96...8c54bea * [8c54bea3](oxidecomputer/console@8c54bea3) oxidecomputer/console#2850 * [a78eac9e](oxidecomputer/console@a78eac9e) oxidecomputer/console#2858 * [320a6c41](oxidecomputer/console@320a6c41) chore: playwright 1.54 * [e0890d02](oxidecomputer/console@e0890d02) oxidecomputer/console#2853 * [3da27b7e](oxidecomputer/console@3da27b7e) oxidecomputer/console#2838 * [99120cdf](oxidecomputer/console@99120cdf) tools: jeeves -> castle in dogfood deploy script * [eb7a44ea](oxidecomputer/console@eb7a44ea) oxidecomputer/console#2844 * [0ee6a973](oxidecomputer/console@0ee6a973) oxidecomputer/console#2845 * [837d6aa2](oxidecomputer/console@837d6aa2) oxidecomputer/console#2840 * [c5c0f3db](oxidecomputer/console@c5c0f3db) oxidecomputer/console#2843 * [83a47614](oxidecomputer/console@83a47614) oxidecomputer/console#2841 * [cdb9f736](oxidecomputer/console@cdb9f736) oxidecomputer/console#2836 * [06c2e727](oxidecomputer/console@06c2e727) oxidecomputer/console#2839 * [e71c8282](oxidecomputer/console@e71c8282) oxidecomputer/console#2835 * [5f338ce8](oxidecomputer/console@5f338ce8) oxidecomputer/console#2811
oxidecomputer/console@e891f96...8c54bea * [8c54bea3](oxidecomputer/console@8c54bea3) oxidecomputer/console#2850 * [a78eac9e](oxidecomputer/console@a78eac9e) oxidecomputer/console#2858 * [320a6c41](oxidecomputer/console@320a6c41) chore: playwright 1.54 * [e0890d02](oxidecomputer/console@e0890d02) oxidecomputer/console#2853 * [3da27b7e](oxidecomputer/console@3da27b7e) oxidecomputer/console#2838 * [99120cdf](oxidecomputer/console@99120cdf) tools: jeeves -> castle in dogfood deploy script * [eb7a44ea](oxidecomputer/console@eb7a44ea) oxidecomputer/console#2844 * [0ee6a973](oxidecomputer/console@0ee6a973) oxidecomputer/console#2845 * [837d6aa2](oxidecomputer/console@837d6aa2) oxidecomputer/console#2840 * [c5c0f3db](oxidecomputer/console@c5c0f3db) oxidecomputer/console#2843 * [83a47614](oxidecomputer/console@83a47614) oxidecomputer/console#2841 * [cdb9f736](oxidecomputer/console@cdb9f736) oxidecomputer/console#2836 * [06c2e727](oxidecomputer/console@06c2e727) oxidecomputer/console#2839 * [e71c8282](oxidecomputer/console@e71c8282) oxidecomputer/console#2835 * [5f338ce8](oxidecomputer/console@5f338ce8) oxidecomputer/console#2811
This PR adds policy data (already present on the sleds overview page) to the individual sled view page.
Before:

After:

This does lose the
Location | Coming soon
line, but I suspect that was added as a means of balancing the rows.It also adjusts the order of cells in a way that makes more sense on a larger window (like having the two "Usable _____" cells in the bottom of the right-hand column), but as most of our layouts are optimized for desktops over mobile, this seemed like it made more sense.
Closes #2837