Animate refresh button #2161
Merged
Animate refresh button #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Oh, great! This looks good.
In an ideal world, I think we'd have a "done" state, like we have with the "copy the external IP" checkmark that fades, so you have some indication that it has completed successfully. I guess the timestamps on the page do change, so you get that, but if your focus is on the spinner, it'd be cool if it also gave you the confirmation that the action had resolved.
But that can wait for a future PR. Looks good.
|
Yes! I was thinking about a tooltip on hover that says when it was last run. Kind of noisy? I don’t know. |
|
I was playing with an animating checkmark (really just cribbing CopyToClipboard); will open a new PR and we can see if it works or not. |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 18, 2024
oxidecomputer/console@2ba444c...6334f0d * [6334f0db](oxidecomputer/console@6334f0db) bump omicron to latest main (no changes) * [46dbd9c8](oxidecomputer/console@46dbd9c8) oxidecomputer/console#2158 * [e94929ab](oxidecomputer/console@e94929ab) try 300ms minTime on RefreshButton SpinnerLoader * [b6da4154](oxidecomputer/console@b6da4154) oxidecomputer/console#2161 * [788389a8](oxidecomputer/console@788389a8) oxidecomputer/console#2157 * [fed9f4d4](oxidecomputer/console@fed9f4d4) oxidecomputer/console#2159 * [aa75f577](oxidecomputer/console@aa75f577) oxidecomputer/console#2160 * [eeb32a78](oxidecomputer/console@eeb32a78) oxidecomputer/console#2153 * [522d3ab1](oxidecomputer/console@522d3ab1) oxidecomputer/console#2156 * [c726356f](oxidecomputer/console@c726356f) oxidecomputer/console#2155 * [e2b0a7d0](oxidecomputer/console@e2b0a7d0) oxidecomputer/console#2151 * [a5af899a](oxidecomputer/console@a5af899a) oxidecomputer/console#2154 * [73263a4e](oxidecomputer/console@73263a4e) of course I didn't push to main without running the tests, why do you ask * [ea108b7e](oxidecomputer/console@ea108b7e) put firewall rules tab first on vpc detail
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 18, 2024
oxidecomputer/console@2ba444c...6334f0d * [6334f0db](oxidecomputer/console@6334f0db) bump omicron to latest main (no changes) * [46dbd9c8](oxidecomputer/console@46dbd9c8) oxidecomputer/console#2158 * [e94929ab](oxidecomputer/console@e94929ab) try 300ms minTime on RefreshButton SpinnerLoader * [b6da4154](oxidecomputer/console@b6da4154) oxidecomputer/console#2161 * [788389a8](oxidecomputer/console@788389a8) oxidecomputer/console#2157 * [fed9f4d4](oxidecomputer/console@fed9f4d4) oxidecomputer/console#2159 * [aa75f577](oxidecomputer/console@aa75f577) oxidecomputer/console#2160 * [eeb32a78](oxidecomputer/console@eeb32a78) oxidecomputer/console#2153 * [522d3ab1](oxidecomputer/console@522d3ab1) oxidecomputer/console#2156 * [c726356f](oxidecomputer/console@c726356f) oxidecomputer/console#2155 * [e2b0a7d0](oxidecomputer/console@e2b0a7d0) oxidecomputer/console#2151 * [a5af899a](oxidecomputer/console@a5af899a) oxidecomputer/console#2154 * [73263a4e](oxidecomputer/console@73263a4e) of course I didn't push to main without running the tests, why do you ask * [ea108b7e](oxidecomputer/console@ea108b7e) put firewall rules tab first on vpc detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1995
Imagine my delight discovering that
invalidateQueriesreturns a promise that completes when the actual query finishes refetching! I confirmed in the RQ source that this behavior is straightforwardly the result of awaiting the fetch calls. That makes it extremely easy to turn on a spinner when it starts and turn it off when it ends. How great is that!2024-04-17-animate-refresh-button.mp4