-
Notifications
You must be signed in to change notification settings - Fork 13
Disable primary NIC delete when multiple NICs present #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
So weird for it to pass in Chrome but fail in FF and Safari. Maybe some accessible name implementation quirk. |
As a test, I gave the PR diff and the test failure output to Gemini 2.5 Pro and it nailed the interpretation and the fix and explains it very nicely (conversation log).
I thought maybe the dropdown was actually covering the other row, like this ![]() But it wasn't, it's just because it's a modal and I guess its overlay captures the pointer events. This is from the trace recorded by a local failure in Firefox: ![]() |
|
Good to know it found that, though! What's confounding me, I think, is that locally the tests are all working just peachy. |
766ed64
to
fb52f5e
Compare
oxidecomputer/console@99a1f00...46e244f * [46e244fd](oxidecomputer/console@46e244fd) oxidecomputer/console#2818 * [9811a9c7](oxidecomputer/console@9811a9c7) element=null on root redirect route to silence warnings * [b8e9f385](oxidecomputer/console@b8e9f385) oxidecomputer/console#2821 * [f097ec96](oxidecomputer/console@f097ec96) oxidecomputer/console#2819 * [585fe913](oxidecomputer/console@585fe913) oxidecomputer/console#2815 * [973d332a](oxidecomputer/console@973d332a) oxidecomputer/console#2817 * [ad61a081](oxidecomputer/console@ad61a081) oxidecomputer/console#2816 * [239e34b9](oxidecomputer/console@239e34b9) oxidecomputer/console#2806 * [376f172f](oxidecomputer/console@376f172f) oxidecomputer/console#2805 * [5c7c8b5b](oxidecomputer/console@5c7c8b5b) oxidecomputer/console#2746 * [1d8c3b76](oxidecomputer/console@1d8c3b76) bump playwright, use more cores to run e2es locally * [f493cb35](oxidecomputer/console@f493cb35) oxidecomputer/console#2772 * [819b99a6](oxidecomputer/console@819b99a6) chore: type error after RR 7.5. this is why we make PRs * [c1134cff](oxidecomputer/console@c1134cff) chore: react-router 7.5.0 * [c1f0d78b](oxidecomputer/console@c1f0d78b) chore: vite 6.3.0 + vitest 3.1.1 * [79c6bc53](oxidecomputer/console@79c6bc53) oxidecomputer/console#2803 * [f454f5ee](oxidecomputer/console@f454f5ee) oxidecomputer/console#2804 * [ccfa5a58](oxidecomputer/console@ccfa5a58) fix deploy-dogfood script when used with a tag * [6196fa48](oxidecomputer/console@6196fa48) invalidate anti-affinity group member lists on instance action success
oxidecomputer/console@99a1f00...46e244f * [46e244fd](oxidecomputer/console@46e244fd) oxidecomputer/console#2818 * [9811a9c7](oxidecomputer/console@9811a9c7) element=null on root redirect route to silence warnings * [b8e9f385](oxidecomputer/console@b8e9f385) oxidecomputer/console#2821 * [f097ec96](oxidecomputer/console@f097ec96) oxidecomputer/console#2819 * [585fe913](oxidecomputer/console@585fe913) oxidecomputer/console#2815 * [973d332a](oxidecomputer/console@973d332a) oxidecomputer/console#2817 * [ad61a081](oxidecomputer/console@ad61a081) oxidecomputer/console#2816 * [239e34b9](oxidecomputer/console@239e34b9) oxidecomputer/console#2806 * [376f172f](oxidecomputer/console@376f172f) oxidecomputer/console#2805 * [5c7c8b5b](oxidecomputer/console@5c7c8b5b) oxidecomputer/console#2746 * [1d8c3b76](oxidecomputer/console@1d8c3b76) bump playwright, use more cores to run e2es locally * [f493cb35](oxidecomputer/console@f493cb35) oxidecomputer/console#2772 * [819b99a6](oxidecomputer/console@819b99a6) chore: type error after RR 7.5. this is why we make PRs * [c1134cff](oxidecomputer/console@c1134cff) chore: react-router 7.5.0 * [c1f0d78b](oxidecomputer/console@c1f0d78b) chore: vite 6.3.0 + vitest 3.1.1 * [79c6bc53](oxidecomputer/console@79c6bc53) oxidecomputer/console#2803 * [f454f5ee](oxidecomputer/console@f454f5ee) oxidecomputer/console#2804 * [ccfa5a58](oxidecomputer/console@ccfa5a58) fix deploy-dogfood script when used with a tag * [6196fa48](oxidecomputer/console@6196fa48) invalidate anti-affinity group member lists on instance action success
This adds an affordance to the instance networking tab, to prevent the deletion of a primary NIC when there are other NICs present.
As called out in #2652, we prevent the user from deleting the primary NIC when there are other NICs present. As Ben notes,
In the linked issue, one approach was to add a modal, giving the user the ability to promote another NIC to primary. Happy to do a part 2 on this if we want to add that functionality, but wanted to at least disable the action for now.