Full page form spacing #2815
Merged
Full page form spacing #2815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
May 2, 2025
app/ui/styles/components/form.css
Outdated
|
|
||
| .ox-form.is-side-modal .ox-divider { | ||
| .ox-form .ox-divider, | ||
| .ox-form .ox-divider:not([hidden]) { |
There was a problem hiding this comment.
I have this to avoid !my-10 since the space-y-... applies it and is therefore more specific. Maybe ! would be better? Unsure
There was a problem hiding this comment.
Hm, yeah. I think I'd rather have the ! — I find the not hidden hack to add specificity counterintuitive.
david-crespo
force-pushed
the
full-page-form-spacing
branch
from
67af49d to
36204c8
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 7, 2025
oxidecomputer/console@99a1f00...46e244f * [46e244fd](oxidecomputer/console@46e244fd) oxidecomputer/console#2818 * [9811a9c7](oxidecomputer/console@9811a9c7) element=null on root redirect route to silence warnings * [b8e9f385](oxidecomputer/console@b8e9f385) oxidecomputer/console#2821 * [f097ec96](oxidecomputer/console@f097ec96) oxidecomputer/console#2819 * [585fe913](oxidecomputer/console@585fe913) oxidecomputer/console#2815 * [973d332a](oxidecomputer/console@973d332a) oxidecomputer/console#2817 * [ad61a081](oxidecomputer/console@ad61a081) oxidecomputer/console#2816 * [239e34b9](oxidecomputer/console@239e34b9) oxidecomputer/console#2806 * [376f172f](oxidecomputer/console@376f172f) oxidecomputer/console#2805 * [5c7c8b5b](oxidecomputer/console@5c7c8b5b) oxidecomputer/console#2746 * [1d8c3b76](oxidecomputer/console@1d8c3b76) bump playwright, use more cores to run e2es locally * [f493cb35](oxidecomputer/console@f493cb35) oxidecomputer/console#2772 * [819b99a6](oxidecomputer/console@819b99a6) chore: type error after RR 7.5. this is why we make PRs * [c1134cff](oxidecomputer/console@c1134cff) chore: react-router 7.5.0 * [c1f0d78b](oxidecomputer/console@c1f0d78b) chore: vite 6.3.0 + vitest 3.1.1 * [79c6bc53](oxidecomputer/console@79c6bc53) oxidecomputer/console#2803 * [f454f5ee](oxidecomputer/console@f454f5ee) oxidecomputer/console#2804 * [ccfa5a58](oxidecomputer/console@ccfa5a58) fix deploy-dogfood script when used with a tag * [6196fa48](oxidecomputer/console@6196fa48) invalidate anti-affinity group member lists on instance action success
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 7, 2025
oxidecomputer/console@99a1f00...46e244f * [46e244fd](oxidecomputer/console@46e244fd) oxidecomputer/console#2818 * [9811a9c7](oxidecomputer/console@9811a9c7) element=null on root redirect route to silence warnings * [b8e9f385](oxidecomputer/console@b8e9f385) oxidecomputer/console#2821 * [f097ec96](oxidecomputer/console@f097ec96) oxidecomputer/console#2819 * [585fe913](oxidecomputer/console@585fe913) oxidecomputer/console#2815 * [973d332a](oxidecomputer/console@973d332a) oxidecomputer/console#2817 * [ad61a081](oxidecomputer/console@ad61a081) oxidecomputer/console#2816 * [239e34b9](oxidecomputer/console@239e34b9) oxidecomputer/console#2806 * [376f172f](oxidecomputer/console@376f172f) oxidecomputer/console#2805 * [5c7c8b5b](oxidecomputer/console@5c7c8b5b) oxidecomputer/console#2746 * [1d8c3b76](oxidecomputer/console@1d8c3b76) bump playwright, use more cores to run e2es locally * [f493cb35](oxidecomputer/console@f493cb35) oxidecomputer/console#2772 * [819b99a6](oxidecomputer/console@819b99a6) chore: type error after RR 7.5. this is why we make PRs * [c1134cff](oxidecomputer/console@c1134cff) chore: react-router 7.5.0 * [c1f0d78b](oxidecomputer/console@c1f0d78b) chore: vite 6.3.0 + vitest 3.1.1 * [79c6bc53](oxidecomputer/console@79c6bc53) oxidecomputer/console#2803 * [f454f5ee](oxidecomputer/console@f454f5ee) oxidecomputer/console#2804 * [ccfa5a58](oxidecomputer/console@ccfa5a58) fix deploy-dogfood script when used with a tag * [6196fa48](oxidecomputer/console@6196fa48) invalidate anti-affinity group member lists on instance action success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small thing, one small but open for discussion.