fix: changed the button lable from Upload to Browse #9275

SamantaTarun · 2023-06-15T05:25:54Z

What: Closes #9274

Issue Description:

The 'Upload' button text in the 'File upload - multiple' PF component is hardcoded and cannot be changed.

I expect to be able to change the button text. E.g., label it as 'Browse' instead of 'Upload'.

Currently, this is not a blocker.

I am trying to use this component for a feature in Apicurio Registry. We are expecting to implement this feature in Q4.

Additional issues:

patternfly-build · 2023-06-15T05:33:34Z

Preview: https://patternfly-react-pr-9275.surge.sh

A11y report: https://patternfly-react-pr-9275-a11y.surge.sh

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx

tlabaj

see inline comment

thatblindgeye

It'd also be worth including a check to ensure either an aria-label or label is passed in. Our NavGroup component has a console warn for something similar

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx

…ternfly-react into tarun_samanta/#9274

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx

thatblindgeye

In addition to the above, since MultipleFileUploadButton is only rendered internally within MultipleFileUploadMain and not exported we'll need to update the MultipleFileUploadMain component to add the new prop and pass it in to where <MultipleFileUploadButton /> is rendered.

Might be better to rename the new label prop to browseButtonText since that'd be more descriptive within MultipleFileUploadMain.

thatblindgeye

This is looking good! The test file needed the prop updated. As mentioned above, could you also add the browseButtonText prop to the MultipleFileUploadMain component (we could give it the same default value of "Upload"). Then you'll want to pass MultipleFileUploadMain's browseButtonText prop into line 40ish where we're rendering <MultipleFileUploadButton />.

...ges/react-core/src/components/MultipleFileUpload/__tests__/MultipleFileUploadButton.test.tsx

SamantaTarun · 2023-07-06T13:02:29Z

if everything has been done for this PR, then please merge. if any changes are required then please let me know.

thatblindgeye

Thanks for working on this!

* fix: changed the button lable from Upload to Browse * change button label from hardcoded text to props element * passes label as Browse * Update MultipleFileUploadMain.tsx * made changes as per your requirements * follow-up * follow-up * follow-up

* fix(Toolbar): resolved typeerror on full page demo (#9355) * chore(TreeView): converted examples to TS (#9286) * fix(ExpandableSection): added ARIA attributes (#9303) * fix(ExpandableSection): added ARIA attributes * Updated failing snapshots due to mismatching generated ID * chore(Tooltip): updated unit tests (#9295) * chore(Tooltip): updated unit tests * Updated mock and tests * Updated based on Austin feedback * Updated integration tests * Removed unused imports * Updated remaining tests using Popper mock * Removed extraenous snapshot test * Removed test * Split out onTooltipHidden test * chore(Card): added tests for new clickable/selectable (#9262) * chore(Card): added tests for new clickable/selectable * Added tests for clickable cards * Updated card with actions test * fix(Slider): reverted taborder (#9293) * fix(chore): Fix deprecated wizard integration tests (#9312) * fix(chore): Fix deprecated wizard integration tests * updated non deprecated test as well --------- Co-authored-by: Titani <[email protected]> * Rebase postv5 (#9393) * chore(deps): bump docs framework (#9370) * chore(docs): Updated screenshots (#9337) * chore(docs): Updated screenshots * updated screenshots after logo update --------- Co-authored-by: Titani <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * chore(deps): bump to latest chore version (#9389) * chore(deps): bump to latest chore version * bump to 16 * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(fileupload): use default readonly text input instead of plain (#9387) * fix(fileupload): use default readonly text input instead of plain * chore(build): snaps * fix(CodeEditor): prevent clicks in textarea from opening fileupload (#9385) * fix(toolbar): added chip container class to toolbar content (#9379) * feat(Menu): added support for tooltips to menu (#9382) * fix(whitespace): Update readme to trigger release * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Toolbar): resolved typeerror on full page demo (#9355) * chore(TreeView): converted examples to TS (#9286) * fix(ExpandableSection): added ARIA attributes (#9303) * fix(ExpandableSection): added ARIA attributes * Updated failing snapshots due to mismatching generated ID * chore(Tooltip): updated unit tests (#9295) * chore(Tooltip): updated unit tests * Updated mock and tests * Updated based on Austin feedback * Updated integration tests * Removed unused imports * Updated remaining tests using Popper mock * Removed extraenous snapshot test * Removed test * Split out onTooltipHidden test * chore(Card): added tests for new clickable/selectable (#9262) * chore(Card): added tests for new clickable/selectable * Added tests for clickable cards * Updated card with actions test * fix(Slider): reverted taborder (#9293) * fix(chore): Fix deprecated wizard integration tests (#9312) * fix(chore): Fix deprecated wizard integration tests * updated non deprecated test as well --------- Co-authored-by: Titani <[email protected]> --------- Co-authored-by: Titani <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Dana Gutride <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> * feat(MenuItem): allow target and rel on links (#9294) * feat(MenuItem): allow target and rel on links * update desc * move desc to right prop * chore(deps): update dependency lint-staged to v13.2.3 (#9335) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(JumpLinks) href does not work properly (#9307) * chore(deps): update dependency eslint to v8.42.0 (#9236) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(SelectToggle): corrected removeEventListener on unmount for v5 (#9380) * fix(Page) allow change of main tag (#9296) * fix(Page) allow change of main tag * rename prop and add it to render method * change prop name and description * update description * Reverted prop name --------- Co-authored-by: Eric Olkowski <[email protected]> * fix(AlertActionLink) support ReactNode as child (#9278) * fix(AlertActionLink) support ReactNode as child * add test * update prop type and description * update test * fix: changed the button lable from Upload to Browse (#9275) * fix: changed the button lable from Upload to Browse * change button label from hardcoded text to props element * passes label as Browse * Update MultipleFileUploadMain.tsx * made changes as per your requirements * follow-up * follow-up * follow-up * fix snaphots --------- Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Titani <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Dana Gutride <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Tarun Samanta <[email protected]>

* fix(Toolbar): resolved typeerror on full page demo (patternfly#9355) * chore(TreeView): converted examples to TS (patternfly#9286) * fix(ExpandableSection): added ARIA attributes (patternfly#9303) * fix(ExpandableSection): added ARIA attributes * Updated failing snapshots due to mismatching generated ID * chore(Tooltip): updated unit tests (patternfly#9295) * chore(Tooltip): updated unit tests * Updated mock and tests * Updated based on Austin feedback * Updated integration tests * Removed unused imports * Updated remaining tests using Popper mock * Removed extraenous snapshot test * Removed test * Split out onTooltipHidden test * chore(Card): added tests for new clickable/selectable (patternfly#9262) * chore(Card): added tests for new clickable/selectable * Added tests for clickable cards * Updated card with actions test * fix(Slider): reverted taborder (patternfly#9293) * fix(chore): Fix deprecated wizard integration tests (patternfly#9312) * fix(chore): Fix deprecated wizard integration tests * updated non deprecated test as well --------- Co-authored-by: Titani <[email protected]> * Rebase postv5 (patternfly#9393) * chore(deps): bump docs framework (patternfly#9370) * chore(docs): Updated screenshots (patternfly#9337) * chore(docs): Updated screenshots * updated screenshots after logo update --------- Co-authored-by: Titani <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * chore(deps): bump to latest chore version (patternfly#9389) * chore(deps): bump to latest chore version * bump to 16 * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(fileupload): use default readonly text input instead of plain (patternfly#9387) * fix(fileupload): use default readonly text input instead of plain * chore(build): snaps * fix(CodeEditor): prevent clicks in textarea from opening fileupload (patternfly#9385) * fix(toolbar): added chip container class to toolbar content (patternfly#9379) * feat(Menu): added support for tooltips to menu (patternfly#9382) * fix(whitespace): Update readme to trigger release * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Toolbar): resolved typeerror on full page demo (patternfly#9355) * chore(TreeView): converted examples to TS (patternfly#9286) * fix(ExpandableSection): added ARIA attributes (patternfly#9303) * fix(ExpandableSection): added ARIA attributes * Updated failing snapshots due to mismatching generated ID * chore(Tooltip): updated unit tests (patternfly#9295) * chore(Tooltip): updated unit tests * Updated mock and tests * Updated based on Austin feedback * Updated integration tests * Removed unused imports * Updated remaining tests using Popper mock * Removed extraenous snapshot test * Removed test * Split out onTooltipHidden test * chore(Card): added tests for new clickable/selectable (patternfly#9262) * chore(Card): added tests for new clickable/selectable * Added tests for clickable cards * Updated card with actions test * fix(Slider): reverted taborder (patternfly#9293) * fix(chore): Fix deprecated wizard integration tests (patternfly#9312) * fix(chore): Fix deprecated wizard integration tests * updated non deprecated test as well --------- Co-authored-by: Titani <[email protected]> --------- Co-authored-by: Titani <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Dana Gutride <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> * feat(MenuItem): allow target and rel on links (patternfly#9294) * feat(MenuItem): allow target and rel on links * update desc * move desc to right prop * chore(deps): update dependency lint-staged to v13.2.3 (patternfly#9335) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(JumpLinks) href does not work properly (patternfly#9307) * chore(deps): update dependency eslint to v8.42.0 (patternfly#9236) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(SelectToggle): corrected removeEventListener on unmount for v5 (patternfly#9380) * fix(Page) allow change of main tag (patternfly#9296) * fix(Page) allow change of main tag * rename prop and add it to render method * change prop name and description * update description * Reverted prop name --------- Co-authored-by: Eric Olkowski <[email protected]> * fix(AlertActionLink) support ReactNode as child (patternfly#9278) * fix(AlertActionLink) support ReactNode as child * add test * update prop type and description * update test * fix: changed the button lable from Upload to Browse (patternfly#9275) * fix: changed the button lable from Upload to Browse * change button label from hardcoded text to props element * passes label as Browse * Update MultipleFileUploadMain.tsx * made changes as per your requirements * follow-up * follow-up * follow-up * fix snaphots --------- Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Titani <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Dana Gutride <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Tarun Samanta <[email protected]>

fix: changed the button lable from Upload to Browse

3ac7180

tlabaj reviewed Jun 15, 2023

View reviewed changes

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx Outdated Show resolved Hide resolved

tlabaj requested changes Jun 15, 2023

View reviewed changes

SamantaTarun added 2 commits June 16, 2023 00:59

change button label from hardcoded text to props element

2d2917d

passes label as Browse

f6fe7b8

SamantaTarun requested a review from tlabaj June 15, 2023 19:51

Update MultipleFileUploadMain.tsx

1b1b6ba

thatblindgeye requested changes Jun 16, 2023

View reviewed changes

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx Outdated Show resolved Hide resolved

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx Outdated Show resolved Hide resolved

SamantaTarun added 2 commits June 17, 2023 01:49

made changes as per your requirements

6f506c0

Merge branch 'tarun_samanta/#9274' of github.com:tarunsamanta2k20/pat…

dc58b4d

…ternfly-react into tarun_samanta/#9274

SamantaTarun requested a review from thatblindgeye June 16, 2023 20:21

tlabaj requested changes Jun 20, 2023

View reviewed changes

packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadButton.tsx Outdated Show resolved Hide resolved

thatblindgeye requested changes Jun 20, 2023

View reviewed changes

SamantaTarun requested a review from thatblindgeye June 20, 2023 19:07

thatblindgeye requested changes Jun 21, 2023

View reviewed changes

...ges/react-core/src/components/MultipleFileUpload/__tests__/MultipleFileUploadButton.test.tsx Outdated Show resolved Hide resolved

follow-up

19a2490

SamantaTarun requested a review from thatblindgeye June 21, 2023 16:09

SamantaTarun added 2 commits June 21, 2023 21:43

follow-up

2f54901

follow-up

84ac133

thatblindgeye approved these changes Jul 6, 2023

View reviewed changes

jenny-s51 approved these changes Jul 7, 2023

View reviewed changes

tlabaj approved these changes Jul 26, 2023

View reviewed changes

tlabaj changed the base branch from main to postV5 July 26, 2023 20:11

tlabaj merged commit bb494e4 into patternfly:postV5 Jul 26, 2023

nicolethoen mentioned this pull request Aug 1, 2023

Bug - File upload multiple - allow ability to change button text #9274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: changed the button lable from Upload to Browse #9275

fix: changed the button lable from Upload to Browse #9275

Uh oh!

SamantaTarun commented Jun 15, 2023

Uh oh!

patternfly-build commented Jun 15, 2023 •

edited

Loading

Uh oh!

Uh oh!

tlabaj left a comment

Uh oh!

thatblindgeye left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thatblindgeye left a comment

Uh oh!

thatblindgeye left a comment

Uh oh!

Uh oh!

SamantaTarun commented Jul 6, 2023

Uh oh!

thatblindgeye left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: changed the button lable from Upload to Browse #9275

fix: changed the button lable from Upload to Browse #9275

Uh oh!

Conversation

SamantaTarun commented Jun 15, 2023

Uh oh!

patternfly-build commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SamantaTarun commented Jul 6, 2023

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

patternfly-build commented Jun 15, 2023 •

edited

Loading