Skip to content

feat(MenuItem): allow target and rel on links #9294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2023
Merged

feat(MenuItem): allow target and rel on links #9294

merged 3 commits into from
Jul 25, 2023

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jun 21, 2023

What: Closes #8593

Adds target and rel to the props list and passed to anchor menu items.

LMK if these would be better off as a generic linkProps property that is spread directly onto the link.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 21, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9294.surge.sh

A11y report: https://patternfly-react-pr-9294-a11y.surge.sh

thatblindgeye
thatblindgeye reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment below, and maybe worth adding a console warning if rel or target are passed without the to prop, but not a blocker

@kmcfaul kmcfaul changed the base branch from main to postV5 July 18, 2023 13:37
tlabaj
tlabaj reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In regards to linkProps I think it is ok as is. If we grouped them we would probably want to also add the to prop and that would be breaking.

@tlabaj
Copy link
Contributor

tlabaj commented Jul 24, 2023

This need rebase then we can merge.

@tlabaj tlabaj merged commit 1fa4d77 into patternfly:postV5 Jul 25, 2023
@thatblindgeye thatblindgeye mentioned this pull request Jul 28, 2023
Closed
tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jul 31, 2023
@kmcfaul
feat(MenuItem): allow target and rel on links (patternfly#9294)
f12c315 
* feat(MenuItem): allow target and rel on links

* update desc

* move desc to right prop
wise-king-sullyman pushed a commit that referenced this pull request Jul 31, 2023
@tlabaj @thatblindgeye
@patternfly-build @mcoker @gitdallas @dgutride @kmcfaul @renovate @dominik-petrik @SamantaTarun
chore: Rebase Post v5 and merge into main (#9419)
8f7da4f 
* fix(Toolbar): resolved typeerror on full page demo (#9355)

* chore(TreeView): converted examples to TS (#9286)

* fix(ExpandableSection): added ARIA attributes (#9303)

* fix(ExpandableSection): added ARIA attributes

* Updated failing snapshots due to mismatching generated ID

* chore(Tooltip): updated unit tests (#9295)

* chore(Tooltip): updated unit tests

* Updated mock and tests

* Updated based on Austin feedback

* Updated integration tests

* Removed unused imports

* Updated remaining tests using Popper mock

* Removed extraenous snapshot test

* Removed test

* Split out onTooltipHidden test

* chore(Card): added tests for new clickable/selectable (#9262)

* chore(Card): added tests for new clickable/selectable

* Added tests for clickable cards

* Updated card with actions test

* fix(Slider): reverted taborder (#9293)

* fix(chore): Fix deprecated wizard integration tests (#9312)

* fix(chore): Fix deprecated wizard integration tests

* updated non deprecated test as well

---------

Co-authored-by: Titani <[email protected]>

* Rebase postv5 (#9393)

* chore(deps): bump docs framework (#9370)

* chore(docs): Updated screenshots (#9337)

* chore(docs): Updated screenshots

* updated screenshots after logo update

---------

Co-authored-by: Titani <[email protected]>

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]

* chore(deps): bump to latest chore version (#9389)

* chore(deps): bump to latest chore version

* bump to 16

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - [email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]

* fix(fileupload): use default readonly text input instead of plain (#9387)

* fix(fileupload): use default readonly text input instead of plain

* chore(build): snaps

* fix(CodeEditor): prevent clicks in textarea from opening fileupload (#9385)

* fix(toolbar): added chip container class to toolbar content (#9379)

* feat(Menu): added support for tooltips to menu (#9382)

* fix(whitespace): Update readme to trigger release

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - [email protected]
 - @patternfly/[email protected]

* fix(Toolbar): resolved typeerror on full page demo (#9355)

* chore(TreeView): converted examples to TS (#9286)

* fix(ExpandableSection): added ARIA attributes (#9303)

* fix(ExpandableSection): added ARIA attributes

* Updated failing snapshots due to mismatching generated ID

* chore(Tooltip): updated unit tests (#9295)

* chore(Tooltip): updated unit tests

* Updated mock and tests

* Updated based on Austin feedback

* Updated integration tests

* Removed unused imports

* Updated remaining tests using Popper mock

* Removed extraenous snapshot test

* Removed test

* Split out onTooltipHidden test

* chore(Card): added tests for new clickable/selectable (#9262)

* chore(Card): added tests for new clickable/selectable

* Added tests for clickable cards

* Updated card with actions test

* fix(Slider): reverted taborder (#9293)

* fix(chore): Fix deprecated wizard integration tests (#9312)

* fix(chore): Fix deprecated wizard integration tests

* updated non deprecated test as well

---------

Co-authored-by: Titani <[email protected]>

---------

Co-authored-by: Titani <[email protected]>
Co-authored-by: patternfly-build <[email protected]>
Co-authored-by: Michael Coker <[email protected]>
Co-authored-by: Dallas <[email protected]>
Co-authored-by: Dana Gutride <[email protected]>
Co-authored-by: Eric Olkowski <[email protected]>

* feat(MenuItem): allow target and rel on links (#9294)

* feat(MenuItem): allow target and rel on links

* update desc

* move desc to right prop

* chore(deps): update dependency lint-staged to v13.2.3 (#9335)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(JumpLinks) href does not work properly (#9307)

* chore(deps): update dependency eslint to v8.42.0 (#9236)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(SelectToggle): corrected removeEventListener on unmount for v5 (#9380)

* fix(Page) allow change of main tag (#9296)

* fix(Page) allow change of main tag

* rename prop and add it to render method

* change prop name and description

* update description

* Reverted prop name

---------

Co-authored-by: Eric Olkowski <[email protected]>

* fix(AlertActionLink) support ReactNode as child (#9278)

* fix(AlertActionLink) support ReactNode as child

* add test

* update prop type and description

* update test

* fix: changed the button lable from Upload to Browse (#9275)

* fix: changed the button lable from Upload to Browse

* change button label from hardcoded text to props element

* passes label as Browse

* Update MultipleFileUploadMain.tsx

* made changes as per your requirements

* follow-up

* follow-up

* follow-up

* fix snaphots

---------

Co-authored-by: Eric Olkowski <[email protected]>
Co-authored-by: Titani <[email protected]>
Co-authored-by: patternfly-build <[email protected]>
Co-authored-by: Michael Coker <[email protected]>
Co-authored-by: Dallas <[email protected]>
Co-authored-by: Dana Gutride <[email protected]>
Co-authored-by: kmcfaul <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominik Petřík <[email protected]>
Co-authored-by: Eric Olkowski <[email protected]>
Co-authored-by: Tarun Samanta <[email protected]>
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@tlabaj @thatblindgeye
@patternfly-build @mcoker @gitdallas @dgutride @kmcfaul @renovate @dominik-petrik @SamantaTarun @nicolethoen
chore: Rebase Post v5 and merge into main (patternfly#9419)
6daead4 
* fix(Toolbar): resolved typeerror on full page demo (patternfly#9355)

* chore(TreeView): converted examples to TS (patternfly#9286)

* fix(ExpandableSection): added ARIA attributes (patternfly#9303)

* fix(ExpandableSection): added ARIA attributes

* Updated failing snapshots due to mismatching generated ID

* chore(Tooltip): updated unit tests (patternfly#9295)

* chore(Tooltip): updated unit tests

* Updated mock and tests

* Updated based on Austin feedback

* Updated integration tests

* Removed unused imports

* Updated remaining tests using Popper mock

* Removed extraenous snapshot test

* Removed test

* Split out onTooltipHidden test

* chore(Card): added tests for new clickable/selectable (patternfly#9262)

* chore(Card): added tests for new clickable/selectable

* Added tests for clickable cards

* Updated card with actions test

* fix(Slider): reverted taborder (patternfly#9293)

* fix(chore): Fix deprecated wizard integration tests (patternfly#9312)

* fix(chore): Fix deprecated wizard integration tests

* updated non deprecated test as well

---------

Co-authored-by: Titani <[email protected]>

* Rebase postv5 (patternfly#9393)

* chore(deps): bump docs framework (patternfly#9370)

* chore(docs): Updated screenshots (patternfly#9337)

* chore(docs): Updated screenshots

* updated screenshots after logo update

---------

Co-authored-by: Titani <[email protected]>

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]

* chore(deps): bump to latest chore version (patternfly#9389)

* chore(deps): bump to latest chore version

* bump to 16

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - [email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]

* fix(fileupload): use default readonly text input instead of plain (patternfly#9387)

* fix(fileupload): use default readonly text input instead of plain

* chore(build): snaps

* fix(CodeEditor): prevent clicks in textarea from opening fileupload (patternfly#9385)

* fix(toolbar): added chip container class to toolbar content (patternfly#9379)

* feat(Menu): added support for tooltips to menu (patternfly#9382)

* fix(whitespace): Update readme to trigger release

* chore(release): releasing packages [ci skip]

 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - @patternfly/[email protected]
 - [email protected]
 - @patternfly/[email protected]

* fix(Toolbar): resolved typeerror on full page demo (patternfly#9355)

* chore(TreeView): converted examples to TS (patternfly#9286)

* fix(ExpandableSection): added ARIA attributes (patternfly#9303)

* fix(ExpandableSection): added ARIA attributes

* Updated failing snapshots due to mismatching generated ID

* chore(Tooltip): updated unit tests (patternfly#9295)

* chore(Tooltip): updated unit tests

* Updated mock and tests

* Updated based on Austin feedback

* Updated integration tests

* Removed unused imports

* Updated remaining tests using Popper mock

* Removed extraenous snapshot test

* Removed test

* Split out onTooltipHidden test

* chore(Card): added tests for new clickable/selectable (patternfly#9262)

* chore(Card): added tests for new clickable/selectable

* Added tests for clickable cards

* Updated card with actions test

* fix(Slider): reverted taborder (patternfly#9293)

* fix(chore): Fix deprecated wizard integration tests (patternfly#9312)

* fix(chore): Fix deprecated wizard integration tests

* updated non deprecated test as well

---------

Co-authored-by: Titani <[email protected]>

---------

Co-authored-by: Titani <[email protected]>
Co-authored-by: patternfly-build <[email protected]>
Co-authored-by: Michael Coker <[email protected]>
Co-authored-by: Dallas <[email protected]>
Co-authored-by: Dana Gutride <[email protected]>
Co-authored-by: Eric Olkowski <[email protected]>

* feat(MenuItem): allow target and rel on links (patternfly#9294)

* feat(MenuItem): allow target and rel on links

* update desc

* move desc to right prop

* chore(deps): update dependency lint-staged to v13.2.3 (patternfly#9335)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(JumpLinks) href does not work properly (patternfly#9307)

* chore(deps): update dependency eslint to v8.42.0 (patternfly#9236)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(SelectToggle): corrected removeEventListener on unmount for v5 (patternfly#9380)

* fix(Page) allow change of main tag (patternfly#9296)

* fix(Page) allow change of main tag

* rename prop and add it to render method

* change prop name and description

* update description

* Reverted prop name

---------

Co-authored-by: Eric Olkowski <[email protected]>

* fix(AlertActionLink) support ReactNode as child (patternfly#9278)

* fix(AlertActionLink) support ReactNode as child

* add test

* update prop type and description

* update test

* fix: changed the button lable from Upload to Browse (patternfly#9275)

* fix: changed the button lable from Upload to Browse

* change button label from hardcoded text to props element

* passes label as Browse

* Update MultipleFileUploadMain.tsx

* made changes as per your requirements

* follow-up

* follow-up

* follow-up

* fix snaphots

---------

Co-authored-by: Eric Olkowski <[email protected]>
Co-authored-by: Titani <[email protected]>
Co-authored-by: patternfly-build <[email protected]>
Co-authored-by: Michael Coker <[email protected]>
Co-authored-by: Dallas <[email protected]>
Co-authored-by: Dana Gutride <[email protected]>
Co-authored-by: kmcfaul <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominik Petřík <[email protected]>
Co-authored-by: Eric Olkowski <[email protected]>
Co-authored-by: Tarun Samanta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - MenuItem - no easy way to make link open in new tab

4 participants

@kmcfaul @patternfly-build @tlabaj @thatblindgeye