Add I2C pin definitions to motor2040 header #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add definitions for the QW/ST connector SDA & SCL pins
|
Thanks for this. As mentioned in issue #889 the intention was for people to access these pins via our I2C class, which has many convenience functions for dealing with I2C comms. I realise though that there is no harm in having these pins defined in Before I approve this PR, could you amend the following comments. See below review. Also, could you include the same three lines for SERVO2040 too please? |
Add `I2C_INT` to `motor2040.hpp` and put pin defs in numeric order.
Add pin definitions for `I2C_INT`, `I2C_SDA`, and `I2C_SCL` to `servo2040.hpp`
|
@ZodiusInfuser Just checking this is ok, and there's nothing else you want me to do before it's mergeable? |
|
Sorry for the delay. Yes, this is good. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add definitions for the QW/ST connector SDA & SCL pins
addresses #889