[DO NOT MERGE!] Fix unicode entrypoint issue

[julienmalard]

Fixes: #252

Test for valid unicode Python identifiers (https://peps.python.org/pep-3131/) in entrypoints. Should reproduce #252 .

[julienmalard]

Thanks, done!

I also have a doubt - in the test files, entrypoints are not quoted. However, in a yaml file, the value (attrs) would always be quoted and the key (module) could optionally be quoted as well.
Are the quotes stripped before arriving at the relevant parts of the code?

I also did not understand the extras part of the original regex and so did not reimplement it. Is this fine, or should we add an example of extras the to tests?

[julienmalard]

Fixes #252

[Secrus]

I also did not understand the extras part of the original regex and so did not reimplement it. Is this fine, or should we add an example of extras the to tests?

It's a legacy distutils/setuptools thing, that allowed for a conditional installation of the entrypoint based on the chosen extra. It's not a standard anymore, but we should keep it working and the new implementation should consider it a viable (although ignored) part of an entrypoint spec.

[Secrus]

@julienmalard do you plan on working on this PR?

[julienmalard]

Thanks for the reminder, @Secrus ! I've added the code to parse and ignore extras, as well as a relevant test. Please let me know if this looks good.

[julienmalard]

Hello @Secrus
Did you have a chance to check these changes?

[Secrus]

@julienmalard I have consulted with @pradyunsg, and we decided that while technically correct, we shouldn't introduce that change while other parts of the ecosystem (like importlib.metadata) don't follow the same rules. If this is important to you, please start a discussion on https://discuss.python.org/ to fix the issue across the whole ecosystem. I will keep the PR open until the consensus is reached.

[julienmalard]

Thanks @Secrus for the update. For reference, this works with Poetry.
I've created a discussion as suggested here: https://discuss.python.org/t/unicode-identifiers-as-python-entrypoints/87540
Do you have any details on which part of importlib.metadata isn't PEP3131-compliant? I'd be happy to start a PR there as well.

[pradyunsg]

We should raise proper exceptions, instead of assertion errors, for issues related to the user provided inputs. (the older asserts were there to guide type checkers).

[julienmalard]

I can do that @pradyunsg
By the way, is the discussion here satisfactory? In brief, they have confirmed that our proposed change here is standards-compliant (more so than the original one) and note that other tools in the ecosystem may require a similar patch as well for unicode to fully function.

[julienmalard]

We should raise proper exceptions, instead of assertion errors, for issues related to the user provided inputs. (the older asserts were there to guide type checkers).

Is there a particular Exception class you would recommend?