-
Notifications
You must be signed in to change notification settings - Fork 52
[DO NOT MERGE!] Fix unicode entrypoint issue #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julienmalard
wants to merge
15
commits into
pypa:main
Choose a base branch
from
julienmalard:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
660cf99
Add unicode entrypoint tests
julienmalard adb6193
Fix for unicode identifiers
julienmalard 6971418
Merge pull request #1 from julienmalard/patch-2
julienmalard 42e7c66
Fix test
julienmalard 096c3c6
Fix tests
julienmalard 7ecc194
Assert `module` is identifier
julienmalard ad98b72
Add error messages
julienmalard 5f4d964
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7ffd661
Oops
julienmalard 6c4fc2b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0961c11
Parse and ignore extras
julienmalard bf0faae
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fe1158e
Add test for extras in console scripts
julienmalard de994ce
Fix extras string (no commas)
julienmalard 982caac
Fix splitting of attrs and extras
julienmalard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should raise proper exceptions, instead of assertion errors, for issues related to the user provided inputs. (the older asserts were there to guide type checkers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that @pradyunsg
By the way, is the discussion here satisfactory? In brief, they have confirmed that our proposed change here is standards-compliant (more so than the original one) and note that other tools in the ecosystem may require a similar patch as well for unicode to fully function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular Exception class you would recommend?