-
Notifications
You must be signed in to change notification settings - Fork 812
Update CircleCI Xcode image #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned burnout on July 6th. https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435 This commit updates Xcode image to 12.5
Nayef211
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
atalman
approved these changes
Jul 7, 2022
mthrok
added a commit
to mthrok/text
that referenced
this pull request
Jul 13, 2022
Recent CircleCI migration pytorch#1818 silently bumped the minimum supported macOS version to 11. PyTorch still supports 10.9 and the ecosystem still uses 10.9. Issue: pytorch#1834 This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary distribution are compatible on macOS=10.9.
atalman
pushed a commit
to atalman/text
that referenced
this pull request
Jul 26, 2022
Recent CircleCI migration pytorch#1818 silently bumped the minimum supported macOS version to 11. PyTorch still supports 10.9 and the ecosystem still uses 10.9. Issue: pytorch#1834 This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary distribution are compatible with macOS=10.9.
atalman
added a commit
that referenced
this pull request
Jul 28, 2022
Recent CircleCI migration #1818 silently bumped the minimum supported macOS version to 11. PyTorch still supports 10.9 and the ecosystem still uses 10.9. Issue: #1834 This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary distribution are compatible with macOS=10.9. Co-authored-by: moto <[email protected]>
atalman
pushed a commit
to atalman/text
that referenced
this pull request
Aug 3, 2022
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned burnout on July 6th. https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435 This commit updates Xcode image to 12.5
atalman
added a commit
that referenced
this pull request
Aug 3, 2022
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned burnout on July 6th. https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435 This commit updates Xcode image to 12.5 Co-authored-by: moto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned
burnout on July 6th. [detail]
https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435
This commit updates Xcode image to 12.5