Skip to content

Update CircleCI Xcode image #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Update CircleCI Xcode image #1818

merged 1 commit into from
Jul 7, 2022

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 7, 2022

CircleCI is removing Xcode 12.4.0 image on August, and there was a planned
burnout on July 6th. [detail]

https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435

This commit updates Xcode image to 12.5

CircleCI is removing Xcode 12.4.0 image on August, and there was a planned
burnout on July 6th.

https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435

This commit updates Xcode image to 12.5
@mthrok mthrok marked this pull request as ready for review July 7, 2022 16:12
@mthrok mthrok requested review from seemethere, malfet and atalman July 7, 2022 16:12
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit a4a81d2 into main Jul 7, 2022
@mthrok mthrok deleted the update-cci-macos branch July 13, 2022 19:57
mthrok added a commit to mthrok/text that referenced this pull request Jul 13, 2022
Recent CircleCI migration pytorch#1818
silently bumped the minimum supported macOS version to 11.

PyTorch still supports 10.9 and the ecosystem still uses 10.9.
Issue: pytorch#1834

This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary
distribution are compatible on macOS=10.9.
mthrok added a commit that referenced this pull request Jul 14, 2022
Recent CircleCI migration #1818
silently bumped the minimum supported macOS version to 11.

PyTorch still supports 10.9 and the ecosystem still uses 10.9.
Issue: #1834

This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary
distribution are compatible with macOS=10.9.
atalman pushed a commit to atalman/text that referenced this pull request Jul 26, 2022
Recent CircleCI migration pytorch#1818
silently bumped the minimum supported macOS version to 11.

PyTorch still supports 10.9 and the ecosystem still uses 10.9.
Issue: pytorch#1834

This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary
distribution are compatible with macOS=10.9.
atalman added a commit that referenced this pull request Jul 28, 2022
Recent CircleCI migration #1818
silently bumped the minimum supported macOS version to 11.

PyTorch still supports 10.9 and the ecosystem still uses 10.9.
Issue: #1834

This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary
distribution are compatible with macOS=10.9.

Co-authored-by: moto <[email protected]>
atalman pushed a commit to atalman/text that referenced this pull request Aug 3, 2022
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned
burnout on July 6th.

https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435

This commit updates Xcode image to 12.5
atalman added a commit that referenced this pull request Aug 3, 2022
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned
burnout on July 6th.

https://app.circleci.com/pipelines/github/pytorch/text/5996/workflows/0bfa021d-b532-4385-b406-c56373c8e9ce/jobs/204435

This commit updates Xcode image to 12.5

Co-authored-by: moto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants