Set MACOSX_DEPLOYMENT_TARGET=10.9 for binary job (#1835) #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent CircleCI migration pytorch#1818 silently bumped the minimum supported macOS version to 11. PyTorch still supports 10.9 and the ecosystem still uses 10.9. Issue: pytorch#1834 This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary distribution are compatible with macOS=10.9.
Nayef211
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent CircleCI migration #1818
silently bumped the minimum supported macOS version to 11.
PyTorch still supports 10.9 and the ecosystem still uses 10.9.
Issue: #1834
This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary
distribution are compatible with macOS=10.9.