Skip to content

9082 educate users on mat mul precision #9103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
May 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
86200a5
initial commit: binding and backends package, no tests.
yaoshiang May 2, 2025
2901b77
Tests for default, high, and highest precision.
yaoshiang May 2, 2025
564685a
clang-format
yaoshiang May 2, 2025
4c0b52e
formatter
yaoshiang May 2, 2025
0d3f44f
Updates to error messages
yaoshiang May 2, 2025
3c333d8
fixed test class names
yaoshiang May 2, 2025
967ccda
typo
yaoshiang May 2, 2025
393257e
typo on error message. unit tested and yapfed.
yaoshiang May 5, 2025
f48d7f6
linter
yaoshiang May 5, 2025
114456b
minor edits.
yaoshiang May 5, 2025
2d05da1
Merge branch '9080-expose-mat_mul_precision' into 9082-educate-users-…
yaoshiang May 6, 2025
587f6e5
initial commit
yaoshiang May 6, 2025
a247bde
adding updated note for __init__
yaoshiang May 6, 2025
69fdb49
removed todo (done!)
yaoshiang May 6, 2025
87cff3d
Updated TODO per review
yaoshiang May 6, 2025
b96f671
Update todo and precision math per comment.
yaoshiang May 6, 2025
c26ad8f
Merge branch 'master' into 9080-expose-mat_mul_precision
yaoshiang May 6, 2025
a825e12
Merge branch '9080-expose-mat_mul_precision' into 9082-educate-users-…
yaoshiang May 6, 2025
8f4b12b
Adding image to second location. Minor typos on README.
yaoshiang May 6, 2025
30d1c19
yapf
yaoshiang May 6, 2025
324bde4
Merge branch '9080-expose-mat_mul_precision' into 9082-educate-users-…
yaoshiang May 6, 2025
e15443f
yapf
yaoshiang May 6, 2025
959b0dc
linter
yaoshiang May 7, 2025
02a5069
parameterized, but in a process isolated way.
yaoshiang May 9, 2025
0205431
Revert "parameterized, but in a process isolated way."
yaoshiang May 9, 2025
8aaa979
parameterized, but in a process isolated way.
yaoshiang May 9, 2025
04516c7
removed dead code
yaoshiang May 9, 2025
c3856c8
added issue for repeatable, unexpected behavior.
yaoshiang May 9, 2025
3fae53c
Merge branch '9080-expose-mat_mul_precision' into 9082-educate-users-…
yaoshiang May 9, 2025
eafc98e
indent
yaoshiang May 9, 2025
6e3fdf9
Updated docstring.
yaoshiang May 9, 2025
a2e2298
Revert "Updated docstring."
yaoshiang May 9, 2025
79af416
Updated docstring.
yaoshiang May 9, 2025
6ff7f59
changed naming of is_on_tpu
yaoshiang May 9, 2025
89c72a8
Merge branch 'master' into 9080-expose-mat_mul_precision
yaoshiang May 9, 2025
9db6e3e
CICD friendly version, hopefully.
yaoshiang May 9, 2025
922b57f
Merge branch '9080-expose-mat_mul_precision' into 9082-educate-users-…
yaoshiang May 9, 2025
4b629d8
Merge branch '9082-educate-users-on-mat-mul-precision' of https://git…
yaoshiang May 9, 2025
bcea8e9
Updates based on comments.
yaoshiang May 9, 2025
56cfbce
addressing comments
yaoshiang May 10, 2025
9c53282
tutorial changes
yaoshiang May 10, 2025
0a55d94
added warning and unit tests.
yaoshiang May 12, 2025
6dc428c
yapf
yaoshiang May 12, 2025
1653cd7
adding new functions to API guide
yaoshiang May 12, 2025
bbd2fe6
Minor fixes to phrases and removed flakey link to API.
yaoshiang May 12, 2025
1196dec
Merge branch 'master' into 9082-educate-users-on-mat-mul-precision
yaoshiang May 12, 2025
fb6b227
post merge unit test fixes.
yaoshiang May 12, 2025
1c5a01e
removed unused image, moved some installs to manual to get github act…
yaoshiang May 12, 2025
7bf49b1
minor typo, plus adjusting build script.
yaoshiang May 15, 2025
6538839
Merge branch 'master' into 9082-educate-users-on-mat-mul-precision
yaoshiang May 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated docstring.
  • Loading branch information
yaoshiang committed May 9, 2025
commit 6e3fdf938d1779bc1a5f6d428b2bc38c67c47f6b
10 changes: 1 addition & 9 deletions test/test_mat_mul_precision.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
"""Numeric tests for default precision of mat mul.

There are three similar test files, suffixed default, high, and highest.
Unfortunately, the precision cannot reliably
be dynamically changed between tensor operations, so
the tests are split into three files to ensure a fresh
environment for each test.
"""
"""Numeric tests for default precision of mat mul."""

import unittest
import time

import torch
import torch_xla
Expand Down