adds the HiFiBerry DAC+HD version #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the driver for the DAC+HD version supporting HiFiBerry's PCM179x based DACs. It also adds PLL control for clock generation. Signed-off-by: Joerg Schambacher <[email protected]>
|
I had to fix up the Signed-off-by: line and Makefile order, and add the 64-bit configs, but otherwise it looks OK. The huge PLL configurability feels like overkill though. |
|
The PLL config has been requested by some customers who want to run the board at 'strange' sample frequencies... Thanks Phil for your help |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 22, 2020
kernel: sound: Add the HiFiBerry DAC+HD version See: raspberrypi/linux#3418 kernel: Fixup rpimem to cleanly unload and reload, and make checkpatch clean See: raspberrypi/linux#3419 kernel: Amend init order of TPM and IMA modules See: raspberrypi/linux#3297 kernel: net: usb: lan78xx: Add .ndo_features_check See: raspberrypi/linux#3395 firmware: platform: Only throttle down from arm_freq firmware: platform: Bump desired ring osc to 3.7 on Pi3/CM3 firmware: arm_loader: Add 2ms delay before resetting SD_IO
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 22, 2020
kernel: sound: Add the HiFiBerry DAC+HD version See: raspberrypi/linux#3418 kernel: Fixup rpimem to cleanly unload and reload, and make checkpatch clean See: raspberrypi/linux#3419 kernel: Amend init order of TPM and IMA modules See: raspberrypi/linux#3297 kernel: net: usb: lan78xx: Add .ndo_features_check See: raspberrypi/linux#3395 firmware: platform: Only throttle down from arm_freq firmware: platform: Bump desired ring osc to 3.7 on Pi3/CM3 firmware: arm_loader: Add 2ms delay before resetting SD_IO
|
I've pushed a forward port to rpi-5.4.y. It required a few changes, so please take a look and confirm it works as expected. |
|
From what I see it should be ok, but I can’t get any of the (more complex) Hifiberry drivers to work (setup is P3 B, just migrated from the 4.19 driver development). They get loaded and seem to probe ok, but the sound cards do not show up. I just want to ask for any advice before spending time and dig deeper. Thanks!
… Am 23.01.2020 um 18:46 schrieb Phil Elwell ***@***.***>:
I've pushed a forward port to rpi-5.4.y. It required a few changes, so please take a look and confirm it works as expected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#3418?email_source=notifications&email_token=ACMQ3VWH5QDULBXE2HVFTPLQ7HJYVA5CNFSM4KJTJZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJYGTJQ#issuecomment-577792422>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACMQ3VTQCJWQ4BVLYS37W3DQ7HJYVANCNFSM4KJTJZHA>.
|
|
Your changes are OK. I've found a problem due to the different order of loading/probing the board and the clock driver. It requires a small fix to work with 5.4. Will do a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the driver for the DAC+HD version supporting HiFiBerry's
PCM179x based DACs. It also adds PLL control for clock generation.
Signed-off-by: Joerg Schambacher [email protected]