Fixup rpimem to cleanly unload and reload, and make checkpatch clean. #3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy name support created a new device that was never destroyed. If the driver was unloaded and reloaded, it failed due to the device already existing. Fixes: "75f1d14 driver: char: rpivid - also support legacy name" Signed-off-by: Dave Stevenson <[email protected]>
pelwell
reviewed
Jan 21, 2020
pelwell
reviewed
Jan 21, 2020
The driver used an unnecessary intermediate void* variable so it only called ERR_PTR once to convert to the error value. Switch to converting as the error arises to remove these intermediate variables. Signed-off-by: Dave Stevenson <[email protected]>
The return value from device_create for the legacy device was never checked or handled. Add the required error handling. Signed-off-by: Dave Stevenson <[email protected]>
Makes checkpatch happier. Signed-off-by: Dave Stevenson <[email protected]>
Stops checkpatch complaining. Signed-off-by: Dave Stevenson <[email protected]>
The error path during probe frees the private memory block, and then promptly dereferences it to log an error message. Use the base device instead of the pointer to it in the private structure. Signed-off-by: Dave Stevenson <[email protected]>
|
Updated. Reworked the conversion from PTR to ERR overall. |
6by9
force-pushed
the
rpi-5.4.y-rpimem
branch
from
e563d16 to
2c07ce2
Compare
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 22, 2020
kernel: sound: Add the HiFiBerry DAC+HD version See: raspberrypi/linux#3418 kernel: Fixup rpimem to cleanly unload and reload, and make checkpatch clean See: raspberrypi/linux#3419 kernel: Amend init order of TPM and IMA modules See: raspberrypi/linux#3297 kernel: net: usb: lan78xx: Add .ndo_features_check See: raspberrypi/linux#3395 firmware: platform: Only throttle down from arm_freq firmware: platform: Bump desired ring osc to 3.7 on Pi3/CM3 firmware: arm_loader: Add 2ms delay before resetting SD_IO
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 22, 2020
kernel: sound: Add the HiFiBerry DAC+HD version See: raspberrypi/linux#3418 kernel: Fixup rpimem to cleanly unload and reload, and make checkpatch clean See: raspberrypi/linux#3419 kernel: Amend init order of TPM and IMA modules See: raspberrypi/linux#3297 kernel: net: usb: lan78xx: Add .ndo_features_check See: raspberrypi/linux#3395 firmware: platform: Only throttle down from arm_freq firmware: platform: Bump desired ring osc to 3.7 on Pi3/CM3 firmware: arm_loader: Add 2ms delay before resetting SD_IO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue noted when JC was trying to unload and reload an overlay for the V4L2 HEVC codec.
Made checkpatch clean (other than DT compatible string) whilst I was at it.