Skip to content

Conversation

@deivid-rodriguez
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

Time to move on. These are EOL.

What is your fix for the problem, implemented in this PR?

Delete all the things.

Make sure the following tasks are checked

Copy link
Contributor

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!!

Copy link
Contributor

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🤩

Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work!

@deivid-rodriguez deivid-rodriguez force-pushed the drop-ruby-26-and-27-support branch from bea7b82 to de30db4 Compare October 27, 2023 18:52
Copy link
Contributor

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally 🙏

@nobu
Copy link
Member

nobu commented Oct 29, 2023

Also Gem::NoAliasYAMLTree.create and Gem::NoAliasYAMLTree#format_time in lib/rubygems/psych_tree.rb can be removed, I think.

Copy link
Contributor

@duckinator duckinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. I reviewed all the non-deleted files and everything looks good to me. I didn't manually inspect the deleted files, but they appear to entirely consist of tool/bundler/*26_gems.rb*, .github/workflows/legacy-git.yml, and over 1,300 cached network requests under vcr_cassettes — and I don't think that should give us problems if CI passes for this. 🙂

@deivid-rodriguez
Copy link
Contributor Author

Yeah! I was a bit disappointed that the work I did at #6208 never paid off, but it finally showed up to remind us to delete 1.3k files 😃

@deivid-rodriguez deivid-rodriguez force-pushed the drop-ruby-26-and-27-support branch from de30db4 to 4a2cbfd Compare November 9, 2023 20:47
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review November 9, 2023 20:47
@deivid-rodriguez
Copy link
Contributor Author

Let's do it!

@deivid-rodriguez deivid-rodriguez merged commit de1a337 into master Nov 10, 2023
@deivid-rodriguez deivid-rodriguez deleted the drop-ruby-26-and-27-support branch November 10, 2023 10:06
segiddins added a commit to rubygems/rubygems-generate_index that referenced this pull request Nov 27, 2023
Mirroring the change to rubygems in ruby/rubygems#7116
ohbarye added a commit to ohbarye/rubygems that referenced this pull request Jan 27, 2024
since 2.6 and 2.7 are EOL and bundler dropped their support by ruby#7116.
matzbot pushed a commit to ruby/ruby that referenced this pull request Jan 27, 2024
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Feb 29, 2024
```
$ ruby -v
ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux]
$ gem update --system
Updating rubygems-update
ERROR:  Error installing rubygems-update:
        rubygems-update-3.5.6 requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.
$
```

https://github.com/rubygems/rubygems/blob/master/CHANGELOG.md#350--2023-12-15
> Drop ruby 2.6 and 2.7 support. Pull request #7116 by deivid-rodriguez

ruby/rubygems#7116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants