Handle realworld specs lost when dropping Ruby 2.7 #7291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
handle-old-realworld-specs
branch
2 times, most recently
from
2e7ee96 to
cd0e35f
Compare
Unfortunately I couldn't find a non-realworld scenario when introducing these specs to prove fixes, and they were specific to ruby 2.7 versions. After dropping Ruby 2.7 support, coverage was lost. For one of them, I'm assuming the coverage loss because the Gemfile was very particular to Ruby 2.7, and I wouldn't know how to do better now, the fix happened a long time ago. We could try patching the current ruby to fake it's Ruby 2.7, but not sure if it's worth the effort. For the other one, I moved it to a spec that runs for all rubies and just makes sure that the Gemfile can be resolved in "reasonable" time.
deivid-rodriguez
force-pushed
the
handle-old-realworld-specs
branch
from
cd0e35f to
2440910
Compare
|
Also included a small change to improve output of specs that assert for "reasonable resolution time". Happy to get suggestions on what's best here. |
martinemde
approved these changes
Dec 15, 2023
|
Thanks! Yeah, it's a big diff, but technically it's files that should've not been removed with #7116 if we wanted to keep the coverage. I guess it's good for now! |
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 21, 2023
Handle realworld specs lost when dropping Ruby 2.7 (cherry picked from commit 481a9ff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Unfortunately I couldn't find a non-realworld scenario when introducing these specs to prove fixes, and they were specific to ruby 2.7 versions.
After dropping Ruby 2.7 support, coverage was lost.
What is your fix for the problem, implemented in this PR?
For one of them, I'm assuming the coverage loss because the Gemfile was very particular to Ruby 2.7, and I wouldn't know how to do better now, the fix happened a long time ago. We could try patching the current ruby to fake it's Ruby 2.7, but not sure if it's worth the effort.
For the other one, I moved it to a spec that runs for all rubies and just makes sure that the Gemfile can be resolved in "reasonable" time.
Make sure the following tasks are checked
WriteDelete tests for features and bug fixes