Skip to content

Does this fix some chromatic issues? #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 27, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
is it the states?
  • Loading branch information
Diaan committed Apr 28, 2025
commit 61d06e2dbae42bbccf88384e23eda36d713f3231
9 changes: 5 additions & 4 deletions chromatic/.storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ const config: StorybookConfig = {
'./stories/**/*.stories.ts',
],
addons: [
'@storybook/addon-a11y',
'@storybook/addon-actions',
'@storybook/addon-a11y',
'@storybook/addon-actions',
'@storybook/addon-storysource',
'@storybook/addon-themes',
'storybook-addon-pseudo-states',
'storybook-addon-pseudo-states',
{
name: '@storybook/addon-essentials',
options: {
Expand All @@ -26,7 +26,8 @@ const config: StorybookConfig = {
autodocs: false
},
staticDirs: [
{ from: '../../packages/themes', to: '/themes' }
{ from: '../../packages/themes', to: '/themes' },
{ from: '../../.storybook/images', to: '/images' }
],
viteFinal: async config => {
const { mergeConfig } = await import('vite');
Expand Down
18 changes: 1 addition & 17 deletions chromatic/.storybook/preview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,7 @@ const preview: Preview = {
padding: 16px;
}
</style>
${singleState.includes(data.id)
? story()
: html`<h1>State: Default <small>(including "disabled")</small></h1>
${story()}
<h1>State: Hover</h1>
<div class="sb-fake-hover">
${story()}
</div>
<h1>State: Active</h1>
<div class="sb-fake-active">
${story()}
</div>
<h1>State: Focus</h1>
<div class="sb-fake-focus-visible">
${story()}
</div>`
}`
${story()}`
},
(story) => {
withThemeFromJSXProvider({
Expand Down