-
Notifications
You must be signed in to change notification settings - Fork 5
Does this fix some chromatic issues? #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
188b78f
Does this fix some chromatic issues?
Diaan 61d06e2
is it the states?
Diaan 76a5534
fix for pseudo states?
Diaan 7ca7ec4
test modes
Diaan 0361bf2
all states
Diaan 9135283
Merge remote-tracking branch 'origin/main' into fix/1979-chromatic-is…
Diaan 8d0d8cb
fix? with fewer themes to save snapshots
Diaan bd3e441
fix viewport issue?
Diaan 7025f6a
Enhance story rendering by adding hover, active, and focus states
Diaan 8093cc1
is 2 stories the problem?
Diaan 6967212
is the story wrapper the problem??
Diaan 5796cd2
with active state
Diaan bc3ae47
without wrappers
Diaan c456669
with 2 story() it does work, but with 3 not? how???
Diaan 8b39827
Merge remote-tracking branch 'origin/main' into fix/1979-chromatic-is…
Diaan 07cf943
fix for loading issues.
Diaan 6cea563
Merge branch 'main' into fix/1979-chromatic-is-broken
Diaan 998b453
Merge branch 'main' into fix/1979-chromatic-is-broken
Diaan cf963df
Merge branch 'fix/1979-chromatic-is-broken' of https://github.com/sl-…
Diaan 80e02cf
put everything back
Diaan d88d191
add fix to chromatic storybook as well 🤦
Diaan f24b6e6
review comments
Diaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
is it the states?
- Loading branch information
commit 61d06e2dbae42bbccf88384e23eda36d713f3231
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.