Skip to content

Does this fix some chromatic issues? #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 27, 2025
Merged

Does this fix some chromatic issues? #1997

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
188b78f
Does this fix some chromatic issues?
Diaan Apr 25, 2025
61d06e2
is it the states?
Diaan Apr 28, 2025
76a5534
fix for pseudo states?
Diaan Apr 28, 2025
7ca7ec4
test modes
Diaan Apr 29, 2025
0361bf2
all states
Diaan Apr 29, 2025
9135283
Merge remote-tracking branch 'origin/main' into fix/1979-chromatic-is…
Diaan Apr 29, 2025
8d0d8cb
fix? with fewer themes to save snapshots
Diaan Apr 29, 2025
bd3e441
fix viewport issue?
Diaan Apr 29, 2025
7025f6a
Enhance story rendering by adding hover, active, and focus states
Diaan Apr 29, 2025
8093cc1
is 2 stories the problem?
Diaan Apr 29, 2025
6967212
is the story wrapper the problem??
Diaan Apr 29, 2025
5796cd2
with active state
Diaan Apr 29, 2025
bc3ae47
without wrappers
Diaan Apr 29, 2025
c456669
with 2 story() it does work, but with 3 not? how???
Diaan Apr 29, 2025
8b39827
Merge remote-tracking branch 'origin/main' into fix/1979-chromatic-is…
Diaan May 14, 2025
07cf943
fix for loading issues.
Diaan May 19, 2025
6cea563
Merge branch 'main' into fix/1979-chromatic-is-broken
Diaan May 19, 2025
998b453
Merge branch 'main' into fix/1979-chromatic-is-broken
Diaan May 26, 2025
cf963df
Merge branch 'fix/1979-chromatic-is-broken' of https://github.com/sl-…
Diaan May 27, 2025
80e02cf
put everything back
Diaan May 27, 2025
d88d191
add fix to chromatic storybook as well 🤦
Diaan May 27, 2025
f24b6e6
review comments
Diaan May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
is 2 stories the problem?
  • Loading branch information
@Diaan
Diaan committed Apr 29, 2025
commit 8093cc1bb65c91c28b3336fa5c8f30e96cf6992c
13 changes: 1 addition & 12 deletions chromatic/.storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,7 @@ const preview: Preview = {
? story()
: html`<h1>State: Default <small>(including "disabled")</small></h1>
${story()}
<h1>State: Hover</h1>
<div class="sb-fake-hover">
${story()}
</div>
<h1>State: Active</h1>
<div class="sb-fake-active">
${story()}
</div>
<h1>State: Focus</h1>
<div class="sb-fake-focus-visible">
${story()}
</div>
${story()}
`
}`
},
Expand Down