Substitution model visualizer #803
Conversation
Modify class definitions, instantiations to incorporate SUBST button Remove SUBST button from controlbar Create SubstTimeline and SubstVisualizer Add a SUBST tab to the sidebar Fix problem with range input not sliding in SUBST visualizer tab 22 march 2019 Remove compile error; confirm can generate code from tree and display Add functionality to handle slider change Add SUBST visualizer functionality to maximum extent permissable by current state of SUBST substitutor Remove excess code and comments left over from testing Add functionality for SUBST to return the actual correct output in the repl output display Remove redundant code Add code to make SUBST slider default to max value Change SUBST display to automatically update to match slider default value Add buttons to SUBST timeline to allow for fine-grained control over stepping through substitution Add checks to disable SUBST timeline control buttons when appropriate "When appropriate" -> for example, all buttons are disabled when the program has not yet been run, and hence there is nothing to step through; button to go to previous step is disabled when already at first step. Add code such that SUBST interpreter is only used when the SUBST tab of the sidebar is open Add keyboard controls to SUBST timeline buttons Add code to transfer default focus to SUBST slider after program evaluation Override default behavior of HTML input slider for SUBST Rationale: default HTML input slider binds up and down to increase and decrease, respectively. This runs counter to the intuition provided by course textbook. Make SUBST slider inline Make SUBST slider inline (via sass)
Pull Request Test Coverage Report for Build 3183
💛 - Coveralls |
* SubstVisualizer and SubstTimeline merged into one component * Tooltip changed to 'Substituter' * Use Blueprint Slider instead of HTML ones * REPL now checks Redux state to evaluate results for Subst * New actions set up to update Redux state * Minor CSS style changes * Changed use of 'bp3' literals to constants * Updated tests
|
Please don't commit package-lock here. Delete the changes on package-lock, and run |
* CSS changes for code display style
* Implemented use of breakpoints to activate SUBST * SUBST now only enabled for Chapter 1 and 2 * Hide REPL, disable resizing on SUBST tab * Minor style changes for SUBST tab, slider * Fix bug where SUBST would be active outside Playground * Implemented blinking style for SUBST tab * Updated snapshots
* Fix for code text being justified in SUBST * SUBST tab now scrolls properly on Chrome * Added vendor prefixes for SUBST CSS * Change occurences of 'code' => 'your program' * Updated snapshots
|
Please fix the tests. Make sure travis pass, do not push changes with --no-verify flag @alcen |
|
If possible, rebase the PR so we only see required changes |
Don't worry, I am not using --no-verify to push. Travis fails because this branch does not work with the current js-slang. This change here will need to be put in --> source-academy/js-slang#320 |
|
Then we'll wait until we get js-slang updated |
|
Can I get some screenshots in the meantime? |
No problem. Here they are: |
expmod is quite a nasty example. These expression blocks will not appear if we only write functions whose body starts with "return". Having said that: the substituter covers all of Source §2, and the handling of applications of functions whose body does not start with "return" is quite straightforward and I hope won't cause issues with the students. |
* SUBST slider can now be moved with < and > keys * Use of SUBST now clears the REPL to prevent display of raw data * Arrow keys no longer used as hotkeys to prevent conflict
* Formatting
No description provided.