Skip to content

SUBST #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 21, 2019
Merged

SUBST #320

merged 22 commits into from
Aug 21, 2019

Conversation

SwampertX
Copy link
Contributor

No description provided.

@SwampertX SwampertX mentioned this pull request Aug 2, 2019
Closed
@coveralls
Copy link

coveralls commented Aug 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1610

  • 414 of 507 (81.66%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.9%) to 87.766%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.ts 2 4 50.0%
src/utils/substStdLib.ts 41 62 66.13%
src/substituter.ts 301 371 81.13%
Totals Coverage Status
Change from base Build 1563: -3.9%
Covered Lines: 2123
Relevant Lines: 2351
💛 - Coveralls

@martin-henz
Copy link
Member

Any instructions how I can use this branch? How can I play with it? What's the language currently supported?

@SwampertX
Copy link
Contributor Author

Any instructions how I can use this branch? How can I play with it? What's the language currently supported?

Still not a working prototype. The quickest way is to

yarn build
node dist/repl/repl.js 1 subst

to run the REPL.

@SwampertX SwampertX force-pushed the yeejian/substituter branch from 8762c10 to ac52319 Compare August 3, 2019 03:50
@SwampertX SwampertX force-pushed the yeejian/substituter branch 2 times, most recently from 9f6f610 to 8e8bd2f Compare August 6, 2019 09:43
@SwampertX SwampertX force-pushed the yeejian/substituter branch from 8e8bd2f to ec08161 Compare August 7, 2019 13:30
@SwampertX
Fix block expression and logical expression
ec14a56 
1. Now logical expressions are evaluated into expressions
2. Block expressions with a single statement as body, and if the
    statement is an Expression Statement with irreducible expression,
    the block will be reduced into undefined.
@alcen alcen mentioned this pull request Aug 8, 2019
Merged
@SwampertX
Copy link
Contributor Author

Last milestone left - make list prelude work.

@SwampertX SwampertX force-pushed the yeejian/substituter branch from 912fc49 to 30e841f Compare August 11, 2019 13:30
@SwampertX SwampertX force-pushed the yeejian/substituter branch from 30e841f to 01017ce Compare August 11, 2019 14:34
@SwampertX SwampertX changed the title WIP: SUBST SUBST Aug 11, 2019
@SwampertX SwampertX force-pushed the yeejian/substituter branch from 0fcf571 to 66e966f Compare August 12, 2019 04:49
@SwampertX SwampertX force-pushed the yeejian/substituter branch 3 times, most recently from e3c3232 to dd3f81f Compare August 18, 2019 02:36
@SwampertX SwampertX force-pushed the yeejian/substituter branch from dd3f81f to e0603d8 Compare August 18, 2019 04:00
@SwampertX SwampertX requested a review from openorclose August 19, 2019 05:23
@SwampertX SwampertX force-pushed the yeejian/substituter branch from 8188443 to 8d2afe7 Compare August 19, 2019 14:30
@SwampertX SwampertX force-pushed the yeejian/substituter branch from fbb109d to 2964ab1 Compare August 20, 2019 04:44
@SwampertX SwampertX force-pushed the yeejian/substituter branch from 084307a to aaa0045 Compare August 20, 2019 07:26
@openorclose
Copy link
Contributor

After much bug fixing, many edge cases have been taken care of. There's probably a few left, such as:
function id(f) { return f; } id(id) === id(id); should be true, but returns false.

Nonetheless, it is a very useful tool, and these bugs can be sorted out along the way.

@openorclose openorclose merged commit 4657f1e into master Aug 21, 2019
@alcen alcen mentioned this pull request Aug 21, 2019
Merged
@thomastanck thomastanck deleted the yeejian/substituter branch August 1, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@openorclose openorclose openorclose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwampertX @coveralls @martin-henz @openorclose