Skip to content

Bump js-slang to latest (0.3.1) #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Bump js-slang to latest (0.3.1) #890

merged 1 commit into from
Aug 21, 2019

Conversation

alcen
Copy link
Contributor

@alcen alcen commented Aug 21, 2019

The current version of js-slang used will crash the Playground when the Substituter is used with libraries like RUNES. In version 0.3.1, this was fixed, and running programs like this will no longer cause a crash:

function stackn_2(n, pic) {
    return n === 1
        ? pic
        : stack_frac(1 / n, pic, stackn_2(n - 1, pic));
}
show(stackn_2(3, heart));

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3216

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.89%

Totals Coverage Status
Change from base Build 3201: 0.0%
Covered Lines: 2671
Relevant Lines: 6486

💛 - Coveralls

Copy link
Contributor

@Aulud Aulud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the js-slang package has been updated to v0.3.1 on npm. However, on the https://github.com/source-academy/js-slang repo, the package.json has not been updated to v0.3.1 nor is there a v0.3.1 branch nor is there any documentation on the changes from v0.2.6 to v0.3.1.

@openorclose Is it safe to bump the version?

@alcen
Copy link
Contributor Author

alcen commented Aug 21, 2019

I see the js-slang package has been updated to v0.3.1 on npm. However, on the https://github.com/source-academy/js-slang repo, the package.json has not been updated to v0.3.1 nor is there a v0.3.1 branch nor is there any documentation on the changes from v0.2.6 to v0.3.1.
@openorclose Is it safe to bump the version?

Yeah, I am aware of this and have highlighted it. Well, seems it has just been merged as I was writing this comment haha: source-academy/js-slang#320

@openorclose
Copy link
Contributor

I see the js-slang package has been updated to v0.3.1 on npm. However, on the https://github.com/source-academy/js-slang repo, the package.json has not been updated to v0.3.1 nor is there a v0.3.1 branch nor is there any documentation on the changes from v0.2.6 to v0.3.1.

@openorclose Is it safe to bump the version?

I have approved and merged the pr already

Copy link
Contributor

@geshuming geshuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lgtm

@geshuming geshuming merged commit c536289 into master Aug 21, 2019
@geshuming geshuming deleted the bump-js-slang branch August 21, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants