Skip to content

Feat: New config option styleguideComponents #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Conversation

sapegin
Copy link
Member

@sapegin sapegin commented Jun 20, 2017

Implements #483.

/cc @bluetidepro

@sapegin sapegin requested a review from MicheleBertoli June 20, 2017 20:19
@codecov-io
Copy link

codecov-io commented Jun 20, 2017

Codecov Report

Merging #504 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #504      +/-   ##
=========================================
+ Coverage   94.47%   94.5%   +0.03%     
=========================================
  Files          95      95              
  Lines        1267    1275       +8     
  Branches      276     280       +4     
=========================================
+ Hits         1197    1205       +8     
  Misses         67      67              
  Partials        3       3
Impacted Files Coverage Δ
scripts/schemas/config.js 97.67% <ø> (ø) ⬆️
scripts/make-webpack-config.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e6125...779cd80. Read the comment docs.

Copy link

@MicheleBertoli MicheleBertoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sapegin sapegin merged commit 12e0ac5 into master Jun 22, 2017
@sapegin sapegin deleted the styleguideComponents branch June 22, 2017 08:09
sapegin added a commit that referenced this pull request Jun 28, 2017
## New features

### Copy pathline to clipboard button

![](http://wow.sapegin.me/3t2u3S0P0L2T/Image%202017-06-28%20at%204.17.16%20PM.png)

(#485, #471 by @SaraVieira)

### Easier way to override style guide React components

New config option `styleguideComponents` to override React components used to render a style guide.

```javascript
module.exports = {
	styleguideComponents: {
		Logo: path.join(__dirname, 'styleguide/components/Logo'),
		StyleGuideRenderer: path.join(__dirname, 'styleguide/components/StyleGuide'),
	},
};
```

(#504)

### Customizable logging

New `logger` option:

```javascript
module.exports = {
	logger: {
    // One of: info, debug, warn
    // Suppress messages
		info: () => {},
    // Override display function
		warn: message => console.warn(`NOOOOOO: ${message}`),
	},
};
```

(#472, #510)

## Bug fixes

* Allow `devServer.watchConfig` to be configured, this also means Vagrant is now supported (#515, #516 by @esphen)
* Default `getExampleFilename` should be case-insensitive (#423, #460, #440, #482)
* Allow dynamic JSS styles
* Isolate search placeholder styles (#509, #491 by @n1313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants