Skip to content

Feat: Customizable logging, new logger option #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2017
Merged

Feat: Customizable logging, new logger option #510

merged 3 commits into from
Jun 24, 2017

Conversation

sapegin
Copy link
Member

@sapegin sapegin commented Jun 23, 2017

@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #510 into master will increase coverage by 0.22%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage    94.5%   94.73%   +0.22%     
==========================================
  Files          95       96       +1     
  Lines        1275     1291      +16     
  Branches      280      281       +1     
==========================================
+ Hits         1205     1223      +18     
+ Misses         67       66       -1     
+ Partials        3        2       -1
Impacted Files Coverage Δ
scripts/utils/sanitizeConfig.js 100% <100%> (ø) ⬆️
scripts/make-webpack-config.js 100% <100%> (ø) ⬆️
scripts/schemas/config.js 97.5% <100%> (-0.18%) ⬇️
loaders/utils/getProps.js 100% <100%> (ø) ⬆️
loaders/styleguide-loader.js 100% <100%> (ø) ⬆️
loaders/props-loader.js 96.66% <100%> (+18.09%) ⬆️
scripts/index.js 100% <100%> (ø) ⬆️
scripts/logger.js 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750addc...afd7bac. Read the comment docs.

@sapegin sapegin merged commit 9d6f92d into master Jun 24, 2017
@sapegin sapegin deleted the logging branch June 24, 2017 07:30
sapegin added a commit that referenced this pull request Jun 28, 2017
## New features

### Copy pathline to clipboard button

![](http://wow.sapegin.me/3t2u3S0P0L2T/Image%202017-06-28%20at%204.17.16%20PM.png)

(#485, #471 by @SaraVieira)

### Easier way to override style guide React components

New config option `styleguideComponents` to override React components used to render a style guide.

```javascript
module.exports = {
	styleguideComponents: {
		Logo: path.join(__dirname, 'styleguide/components/Logo'),
		StyleGuideRenderer: path.join(__dirname, 'styleguide/components/StyleGuide'),
	},
};
```

(#504)

### Customizable logging

New `logger` option:

```javascript
module.exports = {
	logger: {
    // One of: info, debug, warn
    // Suppress messages
		info: () => {},
    // Override display function
		warn: message => console.warn(`NOOOOOO: ${message}`),
	},
};
```

(#472, #510)

## Bug fixes

* Allow `devServer.watchConfig` to be configured, this also means Vagrant is now supported (#515, #516 by @esphen)
* Default `getExampleFilename` should be case-insensitive (#423, #460, #440, #482)
* Allow dynamic JSS styles
* Isolate search placeholder styles (#509, #491 by @n1313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants