[Doc] Fix Icons doc #1692
Merged
[Doc] Fix Icons doc #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebMamba
reviewed
Apr 7, 2024
| @@ -167,9 +167,6 @@ a subdirectory, the *name* will be ``subdirectory:icon_name``. | |||
| Icons On-Demand | |||
| ~~~~~~~~~~~~~~~ | |||
|
|
|||
| `ux.symfony.com/icons`_ has a huge searchable repository of icons | |||
There was a problem hiding this comment.
@smnandre is it the first one or the second one we should keep? the on-demande is different
There was a problem hiding this comment.
I think in RST it's _ to emphasis
There was a problem hiding this comment.
the first does not render correctly
https://symfony.com/bundles/ux-icons/current/index.html#icons-on-demand
There was a problem hiding this comment.
Yes, the _ ... _ is italics in Markdown. In RST, italics is * ... * and bold is ** ... **
But here the problem is that this phrase is wrongly repeated, so let's remove it entirely.
|
Thank you Jorick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sentence appears twice