Skip to content

[Doc] Fix Icons doc #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[Doc] Fix Icons doc #1692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Icons/doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@ a subdirectory, the *name* will be ``subdirectory:icon_name``.
Icons On-Demand
~~~~~~~~~~~~~~~

`ux.symfony.com/icons`_ has a huge searchable repository of icons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smnandre is it the first one or the second one we should keep? the on-demande is different

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in RST it's _ to emphasis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first does not render correctly

https://symfony.com/bundles/ux-icons/current/index.html#icons-on-demand

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thne it's **like that** 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the _ ... _ is italics in Markdown. In RST, italics is * ... * and bold is ** ... **

But here the problem is that this phrase is wrongly repeated, so let's remove it entirely.

from many different sets. This package provides a way to include any icon found on this site _on-demand_.

`ux.symfony.com/icons`_ has a huge searchable repository of icons from many
different sets. This package provides a way to include any icon found on this
site *on-demand*:
Expand Down