Skip to content

Unable to disable build of AWS, HDFS, Kafka and GCP #22819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lissyx opened this issue Oct 8, 2018 · 4 comments
Closed

Unable to disable build of AWS, HDFS, Kafka and GCP #22819

lissyx opened this issue Oct 8, 2018 · 4 comments
Assignees

Comments

@lissyx
Copy link
Contributor

lissyx commented Oct 8, 2018

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): any
  • Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: any
  • TensorFlow installed from (source or binary): source
  • TensorFlow version (use command below): master
  • Python version: N/A
  • Bazel version (if compiling from source): N/A
  • GCC/Compiler version (if compiling from source): N/A
  • CUDA/cuDNN version: N/A
  • GPU model and memory: N/A
  • Exact command to reproduce: ./configure

Describe the problem

When building TensorFlow as a library (and in our case using --config=monolithic), we used to remove as much as possible of the not used features. Recently, this was removed from master in d56c298 for AWS, HDFS, Kafka and GCP.

I understand that that having to deal with multiple optionnally-disabled features can be a huge burden for the future, but is it possible to have some way around ?

@gunan
Copy link
Contributor

gunan commented Oct 12, 2018

Discussed offline.
I will need to reintroduce a way to disable building these into our build system.
I am thinking having these default on, but having --config options such as noaws, nogcp, nohdfs and nokafka
What do you think?

@lissyx
Copy link
Contributor Author

lissyx commented Oct 12, 2018

I think that any solution that is okay for you in term of complexity and allows us to disable should be good :)

@lissyx
Copy link
Contributor Author

lissyx commented Oct 13, 2018

Thanks for that!

@lissyx
Copy link
Contributor Author

lissyx commented Oct 29, 2018

@gunan Hello, I'm testing that on current master, my build command line does include --config=noaws --config=nogcp --config=nohdfs --config=nokafka --config=noignite and yet, checking out the bazel-out/ subdirectories, I find .o and .d files that have been rebuilt, under aws-cpp-sdk-core, aws-cpp-sdk-kinesis and aws-cpp-sdk-s3, am I missing something ?

benjamintanweihao pushed a commit to benjamintanweihao/tensorflow that referenced this issue Dec 5, 2018
…bility to

disable them

Fixes tensorflow#22819

PiperOrigin-RevId: 216931905
muendelezaji added a commit to muendelezaji/tensorflow-on-arm that referenced this issue Dec 14, 2018
muendelezaji added a commit to muendelezaji/tensorflow-on-arm that referenced this issue Dec 14, 2018
perfinion pushed a commit to perfinion/tensorflow that referenced this issue Apr 6, 2019
…bility to

disable them

Fixes tensorflow#22819

PiperOrigin-RevId: 216931905
kaixih pushed a commit to kaixih/tensorflow that referenced this issue Jun 5, 2019
…bility to

disable them

Fixes tensorflow#22819

PiperOrigin-RevId: 216931905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants