Fix AWS, GCP, HDFS, Kafka and Ignite disable config options #23568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like disabling GCP causes an error when trying to use a package in tensorflow/contrib, as the init file automatically imports cloud regardless of whether the user opted to disable it (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/__init__.py#L30). Do you have any suggestions as to how we could fix this? |
gunan
approved these changes
Nov 10, 2018
gunan
added
awaiting testing (then merge)
kokoro:force-run
|
We should be able to make the cloud module under contrib non-breaking if gcp is not used. |
ymodak
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 13, 2018
PiperOrigin-RevId: 221338005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic implemented in commit 3437098 sets
no_<package>_support=trueif theno<package>config option is provided, but checks for a false value (in the tensorflow/BUILD file) to disable the package.This should fully fix Issue #22819