fix(slots): properly warn if slot invoked in setup

[yangxiuxiu1115]

fix #12194

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB	38.1 kB	34.4 kB
vue.global.prod.js	158 kB	58.3 kB	51.9 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.4 kB	18.2 kB	16.6 kB
createApp	54.4 kB	21.2 kB	19.4 kB
createSSRApp	58.6 kB	22.9 kB	20.9 kB
defineCustomElement	59.2 kB	22.7 kB	20.7 kB
overall	68.5 kB	26.4 kB	24 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12195

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12195

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12195

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12195

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12195

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12195

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12195

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12195

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12195

vue

npm i https://pkg.pr.new/vue@12195

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12195

commit: 1591ac6

[edison1105]

The condition will cause the following warning to never trigger. Removing the condition || (ctx && ctx.root === currentInstance.root) will also prevent the warning from triggering in

core/packages/runtime-core/__tests__/componentSlots.spec.ts

Line 324 in 41e10dc

'Slot "default" invoked outside of the render function',

. I think a test case needs to be added to verify the warning will trigger.

[yangxiuxiu1115]

I don't see anything wrong with it .
added a basic warn case

[edison1105]

core/packages/runtime-core/src/vnode.ts

Line 853 in cb34b28

children = { default: children, _ctx: currentRenderingInstance }

if the slot value is a function the rawSlots always has the _ctx key.

so all test cases pass using the following conditions

if (
  __DEV__ &&
  currentInstance &&
  (ctx && ctx.root === currentInstance.root)

[yangxiuxiu1115]

I've added a few test cases, are they correct?

[edison1105]

All test cases are correct.
the proper condition should be:

if (
  __DEV__ &&
  currentInstance &&
  !(ctx === null && currentRenderingInstance) &&
  !(ctx && ctx.root !== currentInstance.root)
)

[yangxiuxiu1115]

cool!!!

[bee1an]

Keep track of the problem

[edison1105]

/ecosystem-ci run

[vue-bot]

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
router	✅ success	✅ success
nuxt	✅ success	✅ success
radix-vue	✅ success	✅ success
pinia	✅ success	✅ success
language-tools	✅ success	✅ success
test-utils	✅ success	✅ success
vueuse	✅ success	✅ success
vitepress	✅ success	✅ success
vue-macros	✅ success	✅ success
primevue	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
quasar	✅ success	✅ success
vant	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success
vuetify	✅ success	✅ success